Revert root cookie override that breaks the Pages build - #294
Merged
Merged
Conversation
Co-authored-by: Kvarkas <3611964+Kvarkas@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Kvarkas
September 11, 2026 07:16
View session
Kvarkas
approved these changes
Sep 11, 2026
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Restore the removed libc constraints in the lockfile to avoid unnecessary native binary downloads.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Reverts the root cookie override that broke SvelteKit’s Pages prerendering by restoring its compatible nested dependency.
Changes:
- Removes the root
cookiedependency and override. - Refreshes the lockfile to restore nested
cookie@0.6.0. - Preserves the intended deployment dependency graph.
File summaries
| File | Summary |
|---|---|
package.json |
Removes the incompatible root cookie configuration. |
package-lock.json |
Restores nested cookie resolution; currently removes libc metadata from native optional packages. |
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GitHub Pages workflow started failing after
cookiewas upgraded at the repository root. That change overrode SvelteKit’s expected transitive dependency and caused prerendering to fail withThe requested module 'cookie' does not provide an export named 'parse'.Root cause
cookiedependency frompackage.jsoncookiev2Dependency resolution
package-lock.jsonso@sveltejs/kitresolves its own compatible nestedcookiedependency againEffect on deploy workflow
{ "dependencies": { "bootstrap-icons": "^1.13.1", "marked": "^18.0.12" } }