Skip to content

Revert root cookie override that breaks the Pages build - #294

Merged
Kvarkas merged 1 commit into
svelteKitfrom
copilot/fix-github-actions-job-failure
Sep 11, 2026
Merged

Kvarkas merged 1 commit into
svelteKitfrom
copilot/fix-github-actions-job-failure

Conversation

Copilot AI commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

The GitHub Pages workflow started failing after cookie was upgraded at the repository root. That change overrode SvelteKit’s expected transitive dependency and caused prerendering to fail with The requested module 'cookie' does not provide an export named 'parse'.

  • Root cause

    • Removed the top-level cookie dependency from package.json
    • Removed the repository-level override that forced all consumers onto cookie v2
  • Dependency resolution

    • Refreshed package-lock.json so @sveltejs/kit resolves its own compatible nested cookie dependency again
    • Avoided broader dependency churn; the change is limited to restoring the dependency graph SvelteKit expects at build time
  • Effect on deploy workflow

    • Restores the server/prerender build path used by the GitHub Pages action
    • Leaves the app’s direct runtime dependencies unchanged aside from removing the incompatible root package
{
  "dependencies": {
    "bootstrap-icons": "^1.13.1",
    "marked": "^18.0.12"
  }
}

Co-authored-by: Kvarkas <3611964+Kvarkas@users.noreply.github.com>
@Kvarkas
Kvarkas marked this pull request as ready for review September 11, 2026 07:28
Copilot AI lite review requested due to automatic review settings September 11, 2026 07:28
@Kvarkas
Kvarkas merged commit 3406eaf into svelteKit Sep 11, 2026
4 checks passed
@Kvarkas
Kvarkas deleted the copilot/fix-github-actions-job-failure branch September 11, 2026 07:28
@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Restore the removed libc constraints in the lockfile to avoid unnecessary native binary downloads.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Reverts the root cookie override that broke SvelteKit’s Pages prerendering by restoring its compatible nested dependency.

Changes:

  • Removes the root cookie dependency and override.
  • Refreshes the lockfile to restore nested cookie@0.6.0.
  • Preserves the intended deployment dependency graph.
File summaries
File Summary
package.json Removes the incompatible root cookie configuration.
package-lock.json Restores nested cookie resolution; currently removes libc metadata from native optional packages.
Review details
  • Files reviewed: 1/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants