Enable in-memory caching in DnsOverHttps and AndroidDns#9594
Open
swankjesse wants to merge 1 commit into
Open
Conversation
yschimke
reviewed
Jul 25, 2026
| /** Drives [StateMachineDnsCall] using the system resolver and [DnsResolver]. */ | ||
| private val queryFactory = | ||
| DnsQuery.Factory { question -> | ||
| dnsCache.`-delegate`.wrap { question -> |
Collaborator
There was a problem hiding this comment.
I think if we do this, we are also responsible for evicting on network changes. So it's if it's the default, we need to ship that wiring also.
This is fine until some oblivious well intentioned grunt makes it the default in an unrelated PR.
yschimke
approved these changes
Jul 25, 2026
The default cache size is 1,000, which is effectively unbounded for mobile apps, which likely call a few dozen API servers, ad networks, and analytics systems. I don't expect DnsOverHttps to be deployed in other environments. If so, it's possible this cache will be problematic, as even 10-second stale results can be problematic for server environments. I'll put an appropriate warning about this in our release notes.
swankjesse
force-pushed
the
jwilson.0725.enable_caches
branch
from
July 25, 2026 21:55
e250c7d to
3cdfe81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default cache size is 1,000, which is effectively unbounded for mobile apps, which likely call a few dozen API servers, ad networks, and analytics systems.
I don't expect DnsOverHttps to be deployed in other environments. If so, it's possible this cache will be problematic, as even 10-second stale results can be problematic for server environments. I'll put an appropriate warning about this in our release notes.