Keep normal Xcode route recovery out of default logs - #194
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
A GUI Xcode process with no open workspace is a normal missing route while another route can continue serving tools. After the partial-catalog behavior introduced in #192, missing catalogs converge in the background, but route-local timeouts still emitted a proxy-wide
Xcode tools are unavailablewarning and repeated retry telemetry at the default log level.This made healthy client sessions appear degraded and continuously polluted the proxy's default stderr output. This PR aligns default-visible logging with client-visible availability without changing process discovery, retry cadence, or background catalog completion.
Changes
infolevel.debug, including expected protocol-level4xxresponses such as an unknown or terminated session.Review focus
inforemains reserved for bounded lifecycle transitions such as startup, route membership, and a catalog becoming available. Detailed recovery and access telemetry remains available withMCP_LOG_LEVEL=debug.Testing
scripts/check.shXcodeMCPProcessRuntimeTests(24 tests)ProxyStdioAdapterTests(13 tests)swift test --no-parallel --filter 'ControlPlaneAuthorityTests|HTTPResponseWriterLoggingTests' -Xswiftc -strict-concurrency=minimalswift test --no-parallel --filter 'ProxyLoggingTests|UpstreamReadinessTests|HTTPHandlerTests|HTTPResponseWriterLoggingTests' -Xswiftc -strict-concurrency=minimalgit diff --checkRelated context