Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/diff-view/src/parts/CommandMap/CommandMap.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ import { showSearch } from '../ShowSearch/ShowSearch.ts'
import { toggleDiffMode } from '../ToggleDiffMode/ToggleDiffMode.ts'
import { toggleWhitespace } from '../ToggleWhitespace/ToggleWhitespace.ts'

const handleDirectMessagePort = (port: any): Promise<void> => handleMessagePort(port, commandMap)

export const commandMap = {
'Diff.getCommandIds': getCommandIds,
'DiffView.create': Create2.create2,
Expand All @@ -67,7 +69,7 @@ export const commandMap = {
'DiffView.handleCopy': wrapCommand(handleCopy),
'DiffView.handleCut': wrapCommand(handleCut),
'DiffView.handleInput': wrapCommand(handleInput),
'DiffView.handleMessagePort': handleMessagePort,
'DiffView.handleMessagePort': handleDirectMessagePort,
'DiffView.handlePaste': wrapCommand(handlePaste),
'DiffView.handleResize': wrapCommand(handleResize),
'DiffView.handleSashPointerDown': wrapCommand(handleSashPointerDown),
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,22 @@
import { PlainMessagePortRpc } from '@lvce-editor/rpc'
import { RendererWorker } from '@lvce-editor/rpc-registry'
import * as RendererProcess from '../RendererProcess/RendererProcess.ts'

export const handleMessagePort = async (port: any): Promise<void> => {
const rpc = await PlainMessagePortRpc.create({ commandMap: {}, messagePort: port })
export const handleMessagePort = async (port: any, viewletCommandMap: Readonly<Record<string, unknown>>): Promise<void> => {
const executeViewletCommand = async (uid: number, command: string, ...args: readonly any[]): Promise<void> => {
const fn = viewletCommandMap[`DiffView.${command}`]
if (typeof fn !== 'function') {
throw new TypeError(`Viewlet command not found: ${command}`)
}
await fn(uid, ...args)
await RendererWorker.invoke('Viewlet.requestRender', uid)
}

const rpc = await PlainMessagePortRpc.create({
commandMap: {
'Viewlet.executeViewletCommand': executeViewletCommand,
},
messagePort: port,
})
RendererProcess.set(rpc)
}
26 changes: 23 additions & 3 deletions packages/diff-view/test/HandleMessagePort.test.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { expect, jest, test } from '@jest/globals'
import { PlainMessagePortRpcParent } from '@lvce-editor/rpc'
import { RendererProcess as RendererProcessRegistry } from '@lvce-editor/rpc-registry'
import { createMockRpc, PlainMessagePortRpcParent } from '@lvce-editor/rpc'
import { RendererProcess as RendererProcessRegistry, RendererWorker } from '@lvce-editor/rpc-registry'
import { handleMessagePort } from '../src/parts/HandleMessagePort/HandleMessagePort.ts'
import * as RendererProcess from '../src/parts/RendererProcess/RendererProcess.ts'

Expand All @@ -13,12 +13,32 @@ test('connects the view directly to the renderer process', async () => {
commandMap: { 'Viewlet.queueCommands': queueCommands },
messagePort: port1,
})
const handleEvent = jest.fn(async (_uid: number, _value: string) => {})

await handleMessagePort(port2)
await handleMessagePort(port2, {
'DiffView.handleEvent': handleEvent,
})
expect(RendererProcess.isConnected()).toBe(true)
await expect(RendererProcess.invoke('Viewlet.queueCommands', 7, [['Viewlet.setDom2', 7, []]])).resolves.toBe(31)
expect(queueCommands).toHaveBeenCalledWith(7, [['Viewlet.setDom2', 7, []]])

const requestRender = jest.fn(async (_uid: number) => {})
RendererWorker.set(
Object.assign(
createMockRpc({
commandMap: {
'Viewlet.requestRender': requestRender,
},
}),
{ dispose: jest.fn() },
),
)
await rendererProcessRpc.invoke('Viewlet.executeViewletCommand', 7, 'handleEvent', 'hello')
expect(handleEvent).toHaveBeenCalledWith(7, 'hello')
expect(requestRender).toHaveBeenCalledWith(7)
await expect(rendererProcessRpc.invoke('Viewlet.executeViewletCommand', 7, 'missing')).rejects.toThrow('Viewlet command not found: missing')

await RendererProcessRegistry.dispose()
await RendererWorker.dispose()
await rendererProcessRpc.dispose()
})