[WRONG BRANCH] fix(responses): honor namespace tool_choice when restoring routed namespace aliases - #327
Draft
luvs01 wants to merge 1 commit into
Draft
[WRONG BRANCH] fix(responses): honor namespace tool_choice when restoring routed namespace aliases#327luvs01 wants to merge 1 commit into
luvs01 wants to merge 1 commit into
Conversation
|
✅ Deterministic PR hygiene checks passed. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⏳ DRAFT
What to do
Its title has been prefixed with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
tool_choice, allowing a noncanonical upstream to cause restoration of tools the caller did not authorize.Description
authorizedAliaseshelper insrc/responses/namespace-tool-compat.tsthat filters the request-local alias map to only those wire names authorized by the turn'stool_choice.authorizedAliases(plan.aliases, toolChoice)when returning the upstream-rewritten body so downstream restoration only ever sees authorized aliases.tests/namespace-tool-compat.test.tsthat asserts excluded namespace aliases are not armed or restored forallowed_tools, forced selectors, and the"none"case.Testing
bun test tests/namespace-tool-compat.test.tsand it passed.bun run typecheck,bun run test, andbun run privacy:scan, and all completed successfully in the environment used for verification.Codex Task