[WRONG BRANCH] fix: exclude caller aborts from sidecar health - #160
[WRONG BRANCH] fix: exclude caller aborts from sidecar health#160luvs01 wants to merge 1 commit into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 29 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
|
Superseded by the current-dev implementation in lidge-jun#2403. This obsolete main-based draft should not be merged. |
Motivation
connect_error, which incremented pool-account failure counters and could trigger failover.Description
abortSignalreason with the linked sidecar signal and skip health recording when the abort came from the caller inrunWebSearch(src/web-search/executor.ts).describeImage(src/vision/describe.ts).tests/sidecar-abort.test.tsverifying that sidecar work still aborts on the turn but does not record an upstream outcome when the client cancels.Testing
bun test tests/sidecar-abort.test.ts, which passed after the changes.bun x tsc --noEmit, which succeeded.bun run privacy:scan, which passed.bun run test; an unrelated timeout/failure in a separate management-provider test stopped the full-suite run (not caused by these changes).Codex Task