Skip to content

[WRONG BRANCH] fix: validate quota reset timestamps - #158

Closed
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-unvalidated-quota-reset-timestamps
Closed

[WRONG BRANCH] fix: validate quota reset timestamps#158
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-unvalidated-quota-reset-timestamps

Conversation

@luvs01

@luvs01 luvs01 commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Upstream reset_at values were stored and returned without ensuring they can form a valid JavaScript Date, which allowed finite but out-of-range values to crash the dashboard via Intl.DateTimeFormat.
  • The goal is to harden quota parsing and formatting so malformed upstream timestamps cannot break the management GUI while preserving existing quota semantics.

Description

  • Add range validation in normalizeResetAt so upstream numeric reset_at values that cannot produce a valid Date are rejected before being stored by the backend (src/codex/quota.ts).
  • Make the GUI quota formatters defensive by centralizing timestamp-to-Date logic in resetAtDate and returning empty labels for invalid dates, and update formatResetAt / formatResetFuture to use it (gui/src/components/QuotaBars.tsx).
  • Add a backend regression test to ensure out-of-range timestamps are discarded but usage percents remain preserved (tests/rate-limit-reset-credits.test.ts).
  • Add a small frontend test that verifies formatResetFuture ignores out-of-range timestamps to prevent RangeError in rendering (gui/tests/intl-formatters.test.ts).

Testing

  • Ran bun run typecheck which completed successfully.
  • Ran focused tests bun test tests/rate-limit-reset-credits.test.ts and cd gui && bun test tests/intl-formatters.test.ts, both of which passed.
  • Ran bun run privacy:scan, cd gui && bun run lint, and cd gui && bun run build, which all completed successfully (build emitted a Vite large-chunk advisory only).
  • Attempted the full repository and GUI test suites; the unrelated broader suites surfaced pre-existing/timeout failures (some dashboard provider polling and a combo-management test) that are not caused by these changes.

Codex Task

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 30 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 3f3d22dc-e47f-45f5-9089-66d862ed5447

📥 Commits

Reviewing files that changed from the base of the PR and between 57140d6 and 73edd59.

📒 Files selected for processing (4)
  • gui/src/components/QuotaBars.tsx
  • gui/tests/intl-formatters.test.ts
  • src/codex/quota.ts
  • tests/rate-limit-reset-credits.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the bug Something isn't working label Aug 8, 2026
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot changed the title fix: validate quota reset timestamps [WRONG BRANCH] fix: validate quota reset timestamps Aug 8, 2026
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev. UI screenshot required.

What to do

  • Retarget this PR to dev — all contributions go to dev.
  • Add a screenshot of the UI change to the PR description.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft August 8, 2026 11:17
@luvs01 luvs01 closed this Aug 19, 2026
@luvs01 luvs01 reopened this Aug 19, 2026
@luvs01

luvs01 commented Aug 22, 2026

Copy link
Copy Markdown
Owner Author

Superseded by the current-dev implementation in lidge-jun#2405. This obsolete main-based draft should not be merged.

@luvs01 luvs01 closed this Aug 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant