[WRONG BRANCH] fix: validate quota reset timestamps - #158
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 30 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
|
Superseded by the current-dev implementation in lidge-jun#2405. This obsolete main-based draft should not be merged. |
Motivation
reset_atvalues were stored and returned without ensuring they can form a valid JavaScriptDate, which allowed finite but out-of-range values to crash the dashboard viaIntl.DateTimeFormat.Description
normalizeResetAtso upstream numericreset_atvalues that cannot produce a validDateare rejected before being stored by the backend (src/codex/quota.ts).Datelogic inresetAtDateand returning empty labels for invalid dates, and updateformatResetAt/formatResetFutureto use it (gui/src/components/QuotaBars.tsx).tests/rate-limit-reset-credits.test.ts).formatResetFutureignores out-of-range timestamps to preventRangeErrorin rendering (gui/tests/intl-formatters.test.ts).Testing
bun run typecheckwhich completed successfully.bun test tests/rate-limit-reset-credits.test.tsandcd gui && bun test tests/intl-formatters.test.ts, both of which passed.bun run privacy:scan,cd gui && bun run lint, andcd gui && bun run build, which all completed successfully (build emitted a Vite large-chunk advisory only).Codex Task