[WRONG BRANCH] fix(gui): ignore stale Startup secondary responses - #120
[WRONG BRANCH] fix(gui): ignore stale Startup secondary responses#120luvs01 wants to merge 1 commit into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 56 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
|
Superseded by the current-dev implementation in lidge-jun#2416. This obsolete main-based draft should not be merged. |
Motivation
settings/trayrequests in a detachedPromise.all(...).then(...)after publishing the primary/api/startup-healthresult, which allowed stale follow-up responses to overwrite newer UI state andsessionStoragewhen a refresh, API base change, or unmount happened.Description
secondaryGenerationReftogui/src/pages/Startup.tsxthat is bumped on mount/unmount/API-base changes and captured perfetchStartupinvocation so secondary callbacks ignore stale generations.secondaryGeneration !== secondaryGenerationRef.currentinside the detachedPromise.all([settingsPromise, trayPromise]).then(...)and bail out when the generation is stale./api/startup-healthdrives the main render while preventing latesettings/trayresponses from overwriting newer state or cache.a superseded settings response cannot overwrite newer Startup cacheingui/tests/startup-revisit-cache.test.tsxthat verifies a stale settings response cannot replace a fresh cache entry.Testing
cd gui && bun test tests/startup-revisit-cache.test.tsxand it passed.cd gui && bun run lint,cd gui && bun run build,bun run typecheck, andbun run privacy:scan, all of which passed for the modified code.cd gui && bun test testsrun where unrelated environment/runtime issues surfaced (missingjest.advanceTimersByTimeandnode:zlibzstdDecompressSync), causing failures in tests unrelated to this change; the failures do not indicate regressions from this patch.Codex Task