Skip to content

[WRONG BRANCH] fix(gui): ignore stale Startup secondary responses - #120

Closed
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-startup-ui-state-race
Closed

[WRONG BRANCH] fix(gui): ignore stale Startup secondary responses#120
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-startup-ui-state-race

Conversation

@luvs01

@luvs01 luvs01 commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Motivation

  • The Startup page started lower-priority settings/tray requests in a detached Promise.all(...).then(...) after publishing the primary /api/startup-health result, which allowed stale follow-up responses to overwrite newer UI state and sessionStorage when a refresh, API base change, or unmount happened.
  • The intent is to let health render immediately but prevent late secondary results from mutating state or cache once a newer lifecycle has started.

Description

  • Add a generation guard secondaryGenerationRef to gui/src/pages/Startup.tsx that is bumped on mount/unmount/API-base changes and captured per fetchStartup invocation so secondary callbacks ignore stale generations.
  • Check secondaryGeneration !== secondaryGenerationRef.current inside the detached Promise.all([settingsPromise, trayPromise]).then(...) and bail out when the generation is stale.
  • Preserve the primary behavior where /api/startup-health drives the main render while preventing late settings/tray responses from overwriting newer state or cache.
  • Add a regression test a superseded settings response cannot overwrite newer Startup cache in gui/tests/startup-revisit-cache.test.tsx that verifies a stale settings response cannot replace a fresh cache entry.

Testing

  • Ran the targeted test cd gui && bun test tests/startup-revisit-cache.test.tsx and it passed.
  • Ran cd gui && bun run lint, cd gui && bun run build, bun run typecheck, and bun run privacy:scan, all of which passed for the modified code.
  • Executed a wider cd gui && bun test tests run where unrelated environment/runtime issues surfaced (missing jest.advanceTimersByTime and node:zlib zstdDecompressSync), causing failures in tests unrelated to this change; the failures do not indicate regressions from this patch.

Codex Task

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 56 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 2afece9b-f868-4e3e-af87-e2c98edab708

📥 Commits

Reviewing files that changed from the base of the PR and between 57140d6 and eeb40e2.

📒 Files selected for processing (2)
  • gui/src/pages/Startup.tsx
  • gui/tests/startup-revisit-cache.test.tsx

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 8, 2026
@github-actions github-actions Bot changed the title fix(gui): ignore stale Startup secondary responses [WRONG BRANCH] fix(gui): ignore stale Startup secondary responses Aug 8, 2026
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev. UI screenshot required.

What to do

  • Retarget this PR to dev — all contributions go to dev.
  • Add a screenshot of the UI change to the PR description.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft August 8, 2026 10:43
@luvs01 luvs01 closed this Aug 19, 2026
@luvs01 luvs01 reopened this Aug 19, 2026
@luvs01

luvs01 commented Aug 22, 2026

Copy link
Copy Markdown
Owner Author

Superseded by the current-dev implementation in lidge-jun#2416. This obsolete main-based draft should not be merged.

@luvs01 luvs01 closed this Aug 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant