Repository navigation
Conversation
Extend RT_TUNE with the Refloat 1.3 tilt smoothing time constants for ATR, torque tilt and tune tilt Accept the extension only as a complete seven-byte group and clamp zero values to avoid division by zero. Feature: Add setpoint smoothing parameters to runtime tuning
lukash
reviewed
Oct 16, 2026
| d->float_conf.torque_tilt.filter.on_speed_time_constant = (float) max(1, cfg[24]) / 100.0f; | ||
| d->float_conf.torque_tilt.filter.off_speed_time_constant = (float) max(1, cfg[25]) / 100.0f; | ||
| d->float_conf.turn_tilt.filter.time_constant = (float) max(1, cfg[26]) / 100.0f; | ||
| } |
Owner
There was a problem hiding this comment.
You've got a gap in the data AFAICS, is that intentional?
The previous batch inside if (len >= 19) { is reading cfg[18] as the last byte. This new batch checks if (len >= 27) {, which is 8 bytes higher, but you're only adding 7 items, you're skipping reading cfg[19] and start at cfg[20].
Looks good otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend RT_TUNE with the Refloat 1.3 tilt smoothing time constants for ATR, torque tilt and tune tilt
Accept the extension only as a complete seven-byte group and clamp zero values to avoid division by zero.
Feature: Add setpoint smoothing parameters to runtime tuning