Repository navigation
Use LEDs consistently - #105
Closed
OakCityDirtyRandy wants to merge 8 commits into
Closed
OakCityDirtyRandy wants to merge 8 commits into
OakCityDirtyRandy wants to merge 8 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are basically two UI changes here. The more important one is to ui.qml.in, where Lights On/Off in Refloat becomes LEDs On/Off for consistency with terms in Refloat Cfg. There is a header named Lights above that I have left alone.
The other change is LEDs Off When Lifted. LEDs are used in both Refloat Cfg and Refloat to mean all lights, so I think consistency is more intuitive than the minor detail of whether the Status bar is unchanged or not.