Repository navigation
fix: upgrade ruff to 0.17 - #289
Merged
hcallahan-lowrisc merged 1 commit intoNov 12, 2026
Merged
Conversation
Ruff 0.17 makes three rules fail the CI lint job: - CPY001 (missing-copyright-notice) is now a stable rule, so the "ALL" selection picks it up. Its default notice-rgx needs a year after "Copyright", which our "Copyright lowRISC contributors" headers don't have, so it flagged every file. Set notice-rgx to match our header in both the full and CI configurations; a file with no header is still flagged. - ICN001 now wants datetime imported as dt. Do so in the three modules that import it. - ISC004 is a new rule that flags unparenthesised implicit string concatenation in a collection literal, which is often a missing comma. The four hits are intentional concatenations; parenthesise them. AI-assisted (Claude Code) — reviewed and approved by author Co-Authored-By: Claude <claude@anthropic.com> Signed-off-by: Harry Callahan <hcallahan@lowrisc.org>
hcallahan-lowrisc
force-pushed
the
deps/ruff-0.17
branch
from
November 12, 2026 12:31
636d40f to
b0d3882
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#288 held ruff at 0.15.15 because 0.17 fails the CI lint job (as seen on #277). This upgrades ruff to 0.17.4 (
uv lock -P ruff, no other packages change) and fixes the three rules that fail:ALLselection picks it up. Its defaultnotice-rgxneeds a year after "Copyright", which ourCopyright lowRISC contributorsheaders don't have, so it flagged all 132 files. Setnotice-rgxto match our header in bothpyproject.tomlandruff-ci.toml; a file with no header is still flagged.import datetime as dt; done in the three modules that import it.Testing
ruff format --checkandruff check --config=ruff-ci.tomlpass with 0.17.4.pytestpasses locally on Python 3.13 (499 tests).lint_commits.pypasses.This PR includes AI-assisted content generated with Claude Code. All changes have been reviewed and are the responsibility of the listed author(s).