Skip to content

fix(site): keep context diagrams complete within their panels - #7921

Merged
loopx-agent merged 1 commit into
mainfrom
codex/pr7884-svg-clipping-20261102
Nov 2, 2026
Merged

loopx-agent merged 1 commit into
mainfrom
codex/pr7884-svg-clipping-20261102

Conversation

@loopx-agent

Copy link
Copy Markdown
Collaborator

The bilingual context diagrams introduced in #7884 clip long read commands and let some pointer rows spill across their panels. Reflow the existing SVG text into multiline spans, grow each containing panel and its canvas, and preserve the complete text and measurements. Article figures now open their original SVG directly by keyboard or tap; intrinsic dimensions match the resources.

The six-file change also removes unused SVG gradients/markers and trailing whitespace. It leaves the article's source revisions, experimental limits, prose and runtime behavior intact.

Validation: public-site production build and the bilingual index smoke passed; all four SVGs parse as static XML. Actual browser text bounds are inside all four viewBoxes. Both long native diagrams preserve their original text except for the shorter column-C heading. Standard premerge and the public-boundary scan passed.

Visual evidence

Tested revision: eb153fafb (full SHA in the commit list). Local public-site static assets and production-build validation; no installed-app or live-account data. Before captures use 8d314af4955c86ea389b0916eda5f1a51f30b966; the site's files are unchanged between that base and the current main baseline. The first viewport stays unchanged. Desktop is 1440×1000 and narrow is 390×844, in both languages. Detailed rows remain dense at article width; opening the original SVG exposes the complete diagram.

First viewports (English/Chinese, desktop/narrow):

first-viewports

Native figure, desktop before/after:

figures-desktop-before-after

Native figure, narrow before/after:

figures-mobile-before-after

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

@loopx-agent loopx-agent left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer: model_agent — gpt-6.1-sol / OpenAI; runtime_reported; reasoning_effort=xhigh

Approval conclusion (author-owned PR; GitHub blocks formal self-approval)

精确 head:eb153fafb0c7928a056a7e264c9299d894652e17。无阻塞 finding。原 #7884 已合并;本次独立审查它的后续修复 #7921,不重放旧批准。

动机 / Motivation

阅读中英文 Context Delivery 文章、需要看完整 Pointer 和选读命令的技术读者。
原图把长命令排在固定宽度面板的一行里,两种语言的尾部越出画布;现在换行并扩展容器,原命令可完整显示。
两张 native 图全部文字落在画布内,正文可用键盘或点按打开原尺寸 SVG。
本次只修复六个既有静态文件,不修改 Context Delivery 协议、实验测量或运行时执行。

改动思路 / Approach

现有 SVG 与 figure 已足够承载完整信息,局部换行和原尺寸链接解决被裁切与细字访问问题,无需增加执行或状态层。
边界为六个既有静态文件:修布局、链接原图并清理未用定义;CLI、模型和 Context Delivery owner 不变。
保留三列和原字号,按实际字体宽度换行,并为新增行同步扩展卡片、箭头位置和画布。原 prose、路径树、caption 与完整来源仍在。相较继续缩小全图或增加新图库,原生 SVG 和浏览器读取入口更符合当前边界。同域整理已应用:删除四图没有引用者的渐变/marker;未增加生成器、截图金样或框架依赖。

具体改动 / Changes

关键代码讲解

  1. native envelope 与命令行 用同一 text 下的 tspan 表示完整字符串;batch-select 和原证据命令在 L141/L149 换行,原空格与 Pointer 均保留。两种语言同步 reflow;native viewBox 变为1360×1020,包含面板随各自文本增高。
  2. 英文 native-path figure 与中文对应位置把现有图片包在同语种相对 href 中,提供可聚焦的原尺寸入口;宽高属性匹配实际资源。#recovery 的周期图也可打开原图,原几何和文字不变。
  3. 四张 SVG 清理未用 definitions 和行尾空白;完整 diff 六文件 +170/-226,没有 runtime/协议、CSS 主版式、测量值或原文章来源更改。源文本逐项比较,除 C 列标题缩短外,全部原文本完整保留。

规范为 docs/development/design.md,spec_revision=214afbb6222c4f0b410a6a1cc084d0262e91925f,并采用 #7884 的具体 post-merge finding。figure-readability、whole-page-evidence、truthful-boundaries 均 implemented:实际边界与读图验证、PR 描述里的三组截图、原文和恢复限定的源对照分别提供证据。

对主干的风险 / Risks

PASS:真实浏览器重现旧命令右端1417.086/1432.383超过1360;修复后四图所有文字都在 viewBox 内。中英文长文章1440×1000与390×844视角已检查,页面无横向溢出;英文键盘 Enter、中文点按实际打开原尺寸 SVG,关闭后原文章仍在。PR 描述的三组截图在 GitHub 实际载入。

PASS:public-site production build、10篇双语文章 index smoke、四图静态 XML/资源检查、文本守恒对照、最终 standard premerge 4 direct + 3 catalog canaries、双语 gate、diff hygiene 和公开边界扫描均通过。XML 无 script/foreignObject/外部资源。这里通过的是静态网站真实路径,未把 CI 元数据或截图存在当作可读性证明;CI 尚未完成的项目由 merge-readiness 单独等待。

我的整体评价 / Verdict

首屏原层级保留,长文章中的三列关系更清楚;窄屏图仍细小,原尺寸入口提供完整阅读。
跨平台字体矩阵、真实屏幕阅读器、线上发布和读者理解未验证。
可见命令的缺失已修复;可选原图访问经过实际操作,保留原字号、完整正文与来源约束,没有增加执行授权或额外确认。长程运行、quota 与模型行为没有改动,也不以图示改进宣称这些收益。现有语义词汇只在原静态示意中复用,没有新状态分类或共享协议。这个六文件边界完整、可回滚,清理与读图改进相称。

English verdict: APPROVE — eb153fafb0c7928a056a7e264c9299d894652e17 keeps complete bilingual diagram commands inside their canvases and provides working original-size reading links; real responsive/native browser checks, site build and standard premerge pass. Font/platform coverage and live publication remain outside this qualification.

@loopx-agent
loopx-agent merged commit fd05b56 into main Nov 2, 2026
7 of 8 checks passed
@loopx-agent
loopx-agent deleted the codex/pr7884-svg-clipping-20261102 branch November 2, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant