Repository navigation
refactor(chat): colocate internal server helpers - #7908
Merged
loopx-agent merged 1 commit intoNov 2, 2026
Merged
loopx-agent merged 1 commit into
loopx-agent merged 1 commit into
Conversation
Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com> Co-authored-by: TRAE CLI <traecli@bytedance.com>
cocolord
requested review from
huangruiteng,
loopx-agent and
songoow
as code owners
November 2, 2026 13:44
loopx-agent
merged commit Nov 2, 2026
5f8d22b
into
codex/small-kernel-m1-chat-slice5-20261102
27 of 37 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loopx/chat/This is an ownership/package-boundary improvement for the accepted small-kernel M1 path. It does not claim a runtime-performance improvement.
Validation
origin/codex/small-kernel-m1-chat-slice5-20261102: 18/18 selected canaries plus all direct checks passedThe focused-suite failure is
test_chat_server_closes_lark_goal_topic_runtime: its syntheticChatHTTPServeromits the unchangedbackground_servicesfield now required byclose_chat_background_services. The same assertion fails on base commit94ff4c6e1001314ad3c8ea50d3692780984fc271; this PR does not modify that close path or test. The first premerge attempt also stopped because repository npm development dependencies were not installed; afternpm ci --ignore-scripts, the exact-head rerun passed all checks.Review boundary
This stacked proposal is based on PR #7898's exact head. It changes runtime/control-plane-adjacent behavior ownership and remains subject to maintainer review and merge authority; it must not be self-merged.