Skip to content

refactor(chat): colocate internal server helpers - #7908

Merged
loopx-agent merged 1 commit into
codex/small-kernel-m1-chat-slice5-20261102from
codex/small-kernel-m1-chat-slice6-20261102
Nov 2, 2026
Merged

loopx-agent merged 1 commit into
codex/small-kernel-m1-chat-slice5-20261102from
codex/small-kernel-m1-chat-slice6-20261102

Conversation

@cocolord

@cocolord cocolord commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • move the internal completed-Todo paging and Goal sub-agent configuration helpers into loopx/chat/
  • update the Chat server, status/control-plane callers, and focused tests to use the package owners
  • remove both legacy top-level entries without compatibility shims and lower the top-level module budget from 132 to 130

This is an ownership/package-boundary improvement for the accepted small-kernel M1 path. It does not claim a runtime-performance improvement.

Validation

  • focused Chat, control-plane, capability, startup-isolation, and architecture suite: 230 passed; one unchanged server-close assertion failed and was reproduced on the exact base head
  • Ruff passed on all changed Python sources and tests
  • source import resolution confirms both package modules and the absence of the legacy entries without site-package path extension
  • an isolated built wheel imports both package modules and contains neither legacy module
  • real registered-state reads returned a 40-item completed-Todo page from 113 completed items, and a Goal sub-agent configuration dry run completed without writing
  • diff-scoped semantic advisory reported no supported new vocabulary carriers
  • standard exact-head premerge passed against origin/codex/small-kernel-m1-chat-slice5-20261102: 18/18 selected canaries plus all direct checks passed

The focused-suite failure is test_chat_server_closes_lark_goal_topic_runtime: its synthetic ChatHTTPServer omits the unchanged background_services field now required by close_chat_background_services. The same assertion fails on base commit 94ff4c6e1001314ad3c8ea50d3692780984fc271; this PR does not modify that close path or test. The first premerge attempt also stopped because repository npm development dependencies were not installed; after npm ci --ignore-scripts, the exact-head rerun passed all checks.

Review boundary

This stacked proposal is based on PR #7898's exact head. It changes runtime/control-plane-adjacent behavior ownership and remains subject to maintainer review and merge authority; it must not be self-merged.

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>
@loopx-agent
loopx-agent merged commit 5f8d22b into codex/small-kernel-m1-chat-slice5-20261102 Nov 2, 2026
27 of 37 checks passed
@loopx-agent
loopx-agent deleted the codex/small-kernel-m1-chat-slice6-20261102 branch November 2, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants