Skip to content

fix(chat): reuse canonical digest owner for native result recovery #7865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huangruiteng merged 2 commits into from
Nov 2, 2026
Merged

fix(chat): reuse canonical digest owner for native result recovery #7865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25783eb
test(chat): characterize native result digest proofs
loopx-agent Nov 2, 2026
4509737
fix(chat): reuse canonical digest owner for native recovery
loopx-agent Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion loopx/control_plane/collaboration/conversation_binding.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import type {JsonObject} from "../effect_program.ts";
import {isDeepStrictEqual} from "node:util";
import {createHash} from "node:crypto";
import {BARE_SHA256_PATTERN} from "../content_digest.ts";
import {EffectRuntimeRequestError} from "../effect_runtime_errors.ts";
import {requireInteger, requireJsonObject, requireNonEmptyString} from "../runtime_decode.ts";
import {requireAutomationCadenceEligibility} from "../quota/automation_cadence.ts";
Expand Down Expand Up @@ -611,7 +612,7 @@ function planContextRecovery(params: JsonObject, row: JsonObject, current: JsonO
&& Number.isFinite(created) && created >= start && created <= end
&& Number.isSafeInteger(proof.start_step_index) && Number(proof.start_step_index) >= 0
&& Number.isSafeInteger(proof.total_steps) && Number(proof.total_steps) > Number(proof.start_step_index) + 1
&& [proof.input_sha256, proof.answer_sha256].every(value => typeof value === "string" && /^[a-f0-9]{64}$/.test(value))
&& [proof.input_sha256, proof.answer_sha256].every(value => typeof value === "string" && BARE_SHA256_PATTERN.test(value))
&& response?.schema_version === "loopx_chat_agent_response_v0"
&& typeof response.message === "string" && response.message.trim().length > 0
&& (adopted === null || adopted.turn_id === failed.turn_id
Expand Down
1 change: 1 addition & 0 deletions tests/control_plane_ts/content_digest_single_owner.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ const CANONICAL_CONSUMERS = [
"control_plane/capabilities/trajectory_input_usage.ts",
"control_plane/capabilities/trajectory_tool_context.ts",
"control_plane/collaboration/chat_mode.ts",
"control_plane/collaboration/conversation_binding.ts",
"control_plane/collaboration/delegation.ts",
"control_plane/collaboration/delegation_result_use.ts",
"control_plane/collaboration/goal_instance_lifecycle.ts",
Expand Down
10 changes: 10 additions & 0 deletions tests/control_plane_ts/conversation_binding.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,16 @@ test("native terminal recovery adopts a result without Turn admission or lost fa
assert.equal(plan.operation, "adopt_native_result");
assert.equal(plan.recovery_eligible, true);
assert.equal(plan.client_turn_id, undefined);
for (const field of ["input_sha256", "answer_sha256"]) {
for (const invalid of [null, false, 1, [], {}, "", "1".repeat(63), "1".repeat(65),
"A".repeat(64), `sha256:${"1".repeat(64)}`]) {
assert.equal(planBoundConversationRequest({...packet, context_recovery: {...packet.context_recovery,
native_observation: {...proof, [field]: invalid}}}).recovery_eligible, false,
`${field} must reject ${JSON.stringify(invalid)}`);
}
assert.equal(planBoundConversationRequest({...packet, context_recovery: {...packet.context_recovery,
native_observation: {...proof, [field]: "abcdef0123456789".repeat(4)}}}).recovery_eligible, true);
}
for (const change of [{source_verified: false}, {stop_observed: true}, {steering_observed: true},
{attachments_present: true}, {native_observation: {...proof, thread_id: "other"}},
{native_observation: {...proof, request_ref: "a".repeat(24)}},
Expand Down
Loading