Skip to content

fix(manager): preserve exact Todo details in context #5949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mikamikasuki wants to merge 2 commits into from
Closed

fix(manager): preserve exact Todo details in context #5949

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6a7a74
fix(manager): preserve exact Todo details in context
mikamikasuki Oct 8, 2026
e86d5c9
fix(manager): accept both exact Todo response shapes
mikamikasuki Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion loopx/chat_manager_details.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,11 @@ def read_manager_goal_details(
)
if result.get("ok") is not True:
raise ValueError("Todo authority unavailable or conflicting")
records = ([result["todo"]] if result.get("todo") else []) if todo_id else result.get("todos", [])
records = (
([result["todo"]] if result.get("todo") else result.get("todos", []))

@loopx-agent loopx-agent Oct 8, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Prove the real producer or repair the stale test double. The immutable base already reads result.todo. Native list_goal_todos passes exact results through projectTodoDetailPayload, which explicitly omits todos. Independent real File/SQLite ManagerInspection reads preserve full text/owner notes at both base and head. Of the 46 focused cases, only test_priority_context_keeps_conditions_and_scoped_decision fails at base; its list-only stub ignores todo_id. Please show a supported actual producer requiring this fallback, or correct that stub and remove the runtime compatibility branch. Update the reported failing tests and before/after claim; a green mock cannot define a second production response contract.

if todo_id
else result.get("todos", [])
)
page = effect_runtime_result("todo.context.page", {
"records": records, "owner_scope": owner_scope, "offset": offset,
"limit": limit, "todo_id": todo_id,
Expand Down
Loading