Repository navigation
Backport dev to next dev pr 164 163 167 - #168
Merged
Merged
Conversation
…BLE pods (#163) * PKA when open now an internal only base level for wedging configurations * Enforce a base "When Open" Pod Keep Alive mode for all BLE pod types * Logic fixes for missing timer init & for no active pod, add defaultPodKeepAliveValue() * Use new hasPairedNonFaultedPod var to test for the ability to do a read pod status
* Count only pairable pods during pairing discovery The discovery loop raised tooManyPodsFound whenever more than one pod peripheral was connected, and handed the first connected device to the pairing session. discoverPods reconnects every known device before scanning, so a user's previous pod that was still alive and known counted as a second pod, and the error told them to move away from pods that were their own. Filter the connected devices on the advertisement's pairable flag (pod id FFFF/FFFE for DASH, pdm id FFFFFFFE for O5), which each device already stores. A device with no advertisement yet is not counted; the scan fills it in for any pod that is advertising. * Treat our own pod as a pairing candidate; pre-connect only our pod devices holds every pod advert the scan has heard, not just ours: didDiscover adds any parseable pod, and the DASH discovery filter matches every DASH pod in range, paired or not. forgetPod prunes the old pod, but the next scan re-adds it if it is still alive. On a pairing retry discoverPods then pre-connected all of them, which is how a second connected pod appeared and raised tooManyPodsFound. Pre-connect only devices in autoConnectIDs, which is what the pre-connect is for: resuming a pod that discovery already picked and that may no longer advertise as pairable. Count that pod as a candidate too, so resuming it still succeeds under the pairable filter from the previous commit.
Contributor
Author
Test✅ build to test phone connected to a DASH pod |
marionbarker
changed the title
Contributor
Author
Test✅ successful test ConfigurationUsed next-dev on my personal phone. Test NarrativeUpon first building:
Next Pod change
|
compton-lac
pushed a commit
to lac-gh-org/LoopWorkspace
that referenced
this pull request
Sep 24, 2026
Brings in loopandlearn/OmnipodKit#168 (backport of dev to next-dev): - loopandlearn/OmnipodKit#167 Count only pairing candidates during pod discovery - loopandlearn/OmnipodKit#163 Pod Keep Alive: a "When Open" base level for all BLE pods - loopandlearn/OmnipodKit#164 Silence pod changes for the non-silent-beep black dot O5 pods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose:
Backport the last 3 PR from the dev branch to next dev.
Background
These PR were generated, tested and squash/merged to the
devbranch, with the merging in the order shown.Use cherry-pick to bring these into the
next-devbranchDetails
devbranch recent historygl =
git log --onelineOmnipodKit % gl -4
173ed51 (HEAD -> dev, origin/dev) Count only pairing candidates during pod discovery (#167)
79991df PKA updates to have an "When Open" base Pod Keep Alive level for all BLE pods (#163)
3962aa5 SIlence Pod changes for the non-silent beep black dot O5 pods (#164)
ce45e20 Merge pull request #162 from loopandlearn/translations_20260917
Apply cherry-pick to
next-devquit xcode
Prepare new branch
Bring in PR 164
git restore -- Localization/Localizable.xcstringsBring in PR 163
Bring in PR 165
Some localization changes did not get added with the last cherry pick.