Fix/dlq timestamp - #7
Conversation
864add0 to
5d27419
Compare
| @@ -98,7 +101,6 @@ private void writeOffsets(Path segment, long offset) throws IOException { | |||
| } | |||
|
|
|||
| public void close() throws IOException { | |||
There was a problem hiding this comment.
minor - can you add the @Override annotation ?
|
|
||
|
|
||
| public class DeadLetterQueueInputPlugin { | ||
| public class DeadLetterQueueInputPlugin implements AutoCloseable{ |
There was a problem hiding this comment.
minor/style - since close is throws IOException this can implement Closeable instead of AutoClosable, which (imo) is a bit more idiomatic
There was a problem hiding this comment.
I don't have strong feelings either way - I added the AutoCloseable interface to allow the use of try.. with resources to help avoid resource leaks/clean up tests. My understanding was the AutoCloseable was more used for code targeting JDK7+, but I guess you are right in that the existing close() throws IOException implies Closeable. (That also means that I need to fix up the method to make it idempotent, which it should have been anyway... ;))
5d27419 to
a589b51
Compare
a589b51 to
5e150cf
Compare
5e150cf to
66d713c
Compare
|
Its this PR related to fix the CI test on master and the 6.x branch? https://travis-ci.org/logstash-plugins/logstash-input-dead_letter_queue |
Change behavior to only respect the 'startTimestamp' flag when no offsets have been committed.
66d713c to
1b82b89
Compare
|
@ph - the reason the tests are failing on 6.x and master is elastic/logstash#8128 (elastic/logstash@d121c58), which removes the toIso8601 method from timestamp. This PR does remove that method, but a less invasive PR should probably go in between. I'll put it up shortly |
|
Thanks @robbavey ! |
Stop timestamp overriding committed offsets
Change behavior to only respect the 'startTimestamp' flag when no offsets have been committed.
Adds more tests.
Fixes #6