Skip to content

build: make Mldoc cross-buildable with Dune - #144

Merged
tiensonqin merged 8 commits into
logseq:masterfrom
tiensonqin:codex/dune-mobile-deps
Aug 26, 2026
Merged

build: make Mldoc cross-buildable with Dune#144
tiensonqin merged 8 commits into
logseq:masterfrom
tiensonqin:codex/dune-mobile-deps

Conversation

@tiensonqin

@tiensonqin tiensonqin commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • wrap the Mldoc library so downstream native builds can depend on a stable module namespace
  • export Nested_link and Pos through the Mldoc entry module
  • pin the merged Dune-enabled Logseq XMLM package
  • modernize CI for the declared OCaml 4.14 minimum and OCaml 5.x
  • make formatting CI read-only instead of auto-committing to PR branches

Validation

  • dune build --root . @install
  • workflow YAML parse
  • parent logseq-chat iOS arm64 cross-compilation through Dune

Dependency

The XMLM dependency was merged to logseq/xmlm master at f6c11f85125da62e6b97f3947e91d6615653c2c3.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@tiensonqin
tiensonqin marked this pull request as ready for review August 26, 2026 10:12
Copilot AI lite review requested due to automatic review settings August 26, 2026 10:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@tiensonqin
tiensonqin merged commit c51b957 into logseq:master Aug 26, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants