Repository navigation
Preserve native list row menu anchors during deletion - #254
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the last action cleared the context menu's cached anchor, detaching native context/swipe modifiers from a retained list row immediately before deletion. This can overlap an iPhone collection batch update and crash with an invalid item count. Keep the anchor until its context-menu node is removed, and retain inferred swipe slots across action changes. Empty menus hide the overflow button.
Add the context-menu-only row style for apps that expose deletion exclusively through the native long-press menu.
Validation: all 184 Apple backend tests pass. A native iOS regression replays 24 graph deletions and checks cell/content identity after removing the last action and exact Local/Remote section counts. It fails before this fix and passes after it. This branch starts from the latest main and contains one new commit.