Repository navigation
Use HTTP/1.1 default connection semantics - #94
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ordinary GET, PUT and snapshot-download requests currently inject
Connection: close. Remove that single default header entry and use HTTP/1.1 default semantics. Each attempt still creates and retires its own TCP/TLS connection; no pooling, WebSocket, TLS, timeout, retry or dependency behavior changes.Existing public Runner tests now inspect requests captured by the independent TLS peer for header omission, preserve WebSocket Upgrade headers, and verify sequential requests complete and retire separate connections.
Validation:
dune runtest -j 1 logseq_sync --forcepass: 313 reported cases, including 139 transport cases, with the original locked host providers and no diagnostic overlay.git diff --checkand this decision document pass. Repository-wide decision validation reports three unchanged historical documents missing required sections.Earlier controlled iPhone comparisons observed truncation with explicit close in 2/2 attempts and complete bodies with explicit keep-alive in 2/2, including reversed order. This identifies a trigger, not the responsible server, intermediary or TLS component. Installed build 1.5877.47 contains the same ordinary-header omission in the earlier diagnostic checkout and reached normal ready/WebSocket startup; it is not the exact clean PR binary, and full cross-ABI validation is not established. Manual initial real-graph download acceptance for the omission version remains pending. No private logs or graph data are included.