Repository navigation
Replace Core timing with Mtime and remove unused Jane Street dependencies - #93
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Journal only used Jane Street Core for two loading-delay measurements and a five-second notice lifetime. Measure elapsed time with Mtime 2.1.0 counters, keep the notice and existing sleep scheduling in seconds, and remove Core plus the audited unused direct Base dependency.
The Dune/opam declarations now use
mtime.clock/mtime. Each lock drops Core and 52 packages exclusive to its closure; retained package versions, Git pins, shared sexplib dependencies and compilerbase-*packages are unchanged. Startup/detail owner checks and the 100ms loading boundary retain their existing behavior, including cancellation and foreground resume.Validation applies to Core-only implementation
45f845con main87d0ccc; subsequent commits change only the decision Markdown, with all source/test/dependency bytes unchanged:dune build @all app/native_embed.exe.o, and full forced tests passed: 21 Alcotest suites / 907 cases, plus 115 named running checks reported separately..cmxaarchives; both built Simulator and iPhoneOS binaries have zero defined/undefined Core or Base symbols and retain Mtime.These are actual file sizes for the combined Core/Base cleanup, not compressed download sizes or independent package attribution.
Limits: production Simulator sign-in was exercised, but Core-only synthetic detail/foreground UI acceptance remains incomplete because startup/fixture issues also reproduced in the baseline. A separately developed local-restoration repair, its 915-case run and its successful offline UI acceptance are excluded from this PR. Both Apple builds use the explicit experimental host-restamp path with
cross_abi_validated=false: target C/Swift, link/platform/provider and signature checks passed, but a complete OCaml iPhoneOS cross ABI and physical-device runtime are unverified; no iPhone installation was performed. Decision-document validation passes for this change; the full document check still reports three unchanged historical documents missing sections.GitHub Journal CI run 39032923420 passed on exact head
7703c9a9ab55b8d3a4298cdba090a9508bcfb32e, including all-target/native-object build, full regressions, helper checks and final cache verification. Its uploaded installed-package list also contains no Core or Base (compilerbase-*packages are retained).A fresh independent read-only
journal-code-reviewsession completed on published head7703c9a9ab55b8d3a4298cdba090a9508bcfb32ewith no evidence-backed findings. It independently confirmed the GitHub-exported diff matches the local exact range and excludes the separate restoration repair. No merge is requested.