Skip to content

Remove unused callback and replan work from overlay commits - #91

Merged
RCmerci merged 4 commits into
mainfrom
codex/overlay-dead-commit-work-20261017
Oct 17, 2026
Merged

RCmerci merged 4 commits into
mainfrom
codex/overlay-dead-commit-work-20261017

Conversation

@RCmerci

@RCmerci RCmerci commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

Overlay commits collected subscriber callbacks that were immediately discarded, while ordinary outbox replanning constructed structural snapshot roots that none of its point-read consumers use. Remove these allocations and their private return/accumulator plumbing, keeping dispatcher delivery, capacity reservations, callback lifecycle, block/page effects and final outbox ordering unchanged.

Validation:

  • Baseline: 139 existing overlay change/concurrency/sync/asset cases passed.
  • After simplification: 182 targeted overlay cases passed, including No_change, retained effect order and frozen snapshots, transitive dependencies, asset references, self-unlisten and close/unlisten waits.
  • dune build -j 4 @all app/native_embed.exe.o passed.
  • dune runtest -j 4 --force passed: 21 Alcotest suites / 898 cases, plus the other Dune checks.
  • Both new decision documents validate. Whole-repository document validation still reports three unchanged historical documents missing required sections (2026-10-06 timeline soft edge, 2026-10-09 favorites soft header, 2026-09-28 bottom capsules).

No protected spec, public interface, Dune, dependency, platform or existing test changes.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-17T07:08:42.066094Z d5ec2d8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@RCmerci
RCmerci merged commit 1dcba8d into main Oct 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant