Repository navigation
fix(extensions): drop the git URL source parameter - #90
Merged
Merged
Conversation
alexrashed
approved these changes
Oct 12, 2026
carole-lavillonniere
marked this pull request as ready for review
October 12, 2026 10:15
carole-lavillonniere
force-pushed
the
cosy-1084-remove-git-url-extension-installs
branch
from
October 12, 2026 12:31
56fed58 to
b8cae0c
Compare
purcell
approved these changes
Oct 12, 2026
Contributor
Author
|
@HarshCasper what's the reason why merging is blocked here? |
HarshCasper
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
LocalStack rejects git URLs for extension installs from the next release on (localstack/localstack-pro#9309). They have failed since 2026.4.0 anyway, as the image has no working
git. Thelocalstack-extensionstool still offers asourceparameter forgit+https://URLs, so an agent using it always gets an install failure.Ticket: COSY-1084
Changes
localstack-extensionstool: remove thesourceparameter;installnow requiresname, likeuninstall. The "not found" message no longer suggests a git URL.validateExtensionTarget: remove the git URL pattern and its checks. A git URL passed asnameis rejected by the existing PyPI name pattern.source.Tests
tsc --noEmit,jest(265 tests) and Prettier pass.