Skip to content

fix(extensions): drop the git URL source parameter - #90

Merged
HarshCasper merged 1 commit into
mainfrom
cosy-1084-remove-git-url-extension-installs
Oct 15, 2026
Merged

HarshCasper merged 1 commit into
mainfrom
cosy-1084-remove-git-url-extension-installs

Conversation

@carole-lavillonniere

Copy link
Copy Markdown
Contributor

Motivation

LocalStack rejects git URLs for extension installs from the next release on (localstack/localstack-pro#9309). They have failed since 2026.4.0 anyway, as the image has no working git. The localstack-extensions tool still offers a source parameter for git+https:// URLs, so an agent using it always gets an install failure.

Ticket: COSY-1084

Changes

  • localstack-extensions tool: remove the source parameter; install now requires name, like uninstall. The "not found" message no longer suggests a git URL.
  • validateExtensionTarget: remove the git URL pattern and its checks. A git URL passed as name is rejected by the existing PyPI name pattern.
  • Analytics: stop recording source.
  • Tests: replace the git source cases with one checking that a git URL is rejected.

Tests

  • tsc --noEmit, jest (265 tests) and Prettier pass.

@carole-lavillonniere
carole-lavillonniere marked this pull request as ready for review October 12, 2026 10:15
@carole-lavillonniere
carole-lavillonniere force-pushed the cosy-1084-remove-git-url-extension-installs branch from 56fed58 to b8cae0c Compare October 12, 2026 12:31
@carole-lavillonniere

Copy link
Copy Markdown
Contributor Author

@HarshCasper what's the reason why merging is blocked here?

@HarshCasper
HarshCasper merged commit 6fd75ea into main Oct 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants