-
Notifications
You must be signed in to change notification settings - Fork 39
DOC-404: Document orphaned containers after Docker Compose stop #894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -154,6 +154,27 @@ For example, a container which attempts to deploy a stack and interact with the | |||||||||
|
|
||||||||||
| Refer to our [network troubleshooting guide](/aws/customization/networking/) covering several scenarios. | ||||||||||
|
|
||||||||||
| ### Why are some containers left behind after I stop LocalStack with Docker Compose? | ||||||||||
|
|
||||||||||
| When LocalStack shuts down, it cleans up the auxiliary containers it started, including k3d containers that back an EKS cluster. | ||||||||||
|
|
||||||||||
| Docker Compose sends `SIGTERM` to the container and then, after a grace period of 10 seconds, follows up with `SIGKILL`. | ||||||||||
| That default window might be too short for LocalStack to finish its cleanup in some scenarios, so it is killed mid-teardown and the containers survive as orphans. | ||||||||||
|
Comment on lines
+161
to
+162
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
|
|
||||||||||
| To give LocalStack enough time to shut down cleanly, raise `stop_grace_period` on the LocalStack service in your `docker-compose.yml` (for example, `3m`): | ||||||||||
|
|
||||||||||
| ```yaml | ||||||||||
| services: | ||||||||||
| localstack: | ||||||||||
| image: localstack/localstack-pro:latest | ||||||||||
| stop_grace_period: 3m | ||||||||||
| # ... | ||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
| ``` | ||||||||||
|
|
||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
| If a previous run already left containers behind, remove them before starting LocalStack again. | ||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
|
|
||||||||||
| This applies to Docker Compose specifically. Starting LocalStack with the CLI is not affected, as the CLI waits for LocalStack to finish shutting down. | ||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. question: What do we refer as CLI here ? the legacy localstack cli or lstk ? |
||||||||||
|
|
||||||||||
| ### How to resolve the pull rate limit issue for LocalStack's Docker image? | ||||||||||
|
|
||||||||||
| If you receive `ERROR: toomanyrequests: Too Many Requests.` when pulling the LocalStack Docker image, you have reached your pull rate limit. | ||||||||||
|
|
||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to specifically mention the k3d here. This can go to the EKS doc.