[paolosalvatori]

Motivation

#141 asks Windows users of Git Bash and MSYS2 to export MSYS_NO_PATHCONV=1 and adapts the scripts to it, but the Samples CI runs only on Linux, so nothing checks that the samples work from Git Bash.
This adds a Windows job that runs every sample there, on demand, as a reproduction of that setup.
It is stacked on #141 and will be retargeted to main once that pull request merges.

Fixes SMF-980

Changes

• A new windows input of the manual run starts the new windows job instead of the Linux matrix. The setup job then selects every sample, on amd64, the architecture of the Windows runner, whatever run_mode and arch say.
• The job runs on windows-latest and uses Git Bash, the default bash shell of Windows runners, with MSYS_NO_PATHCONV=1 set as the README asks. run-samples.sh drives each sample exactly as in the Linux job, and a failed sample is retried once on a fresh emulator, as there.
• The emulator is a Linux image, and Docker on the Windows runner runs Windows containers, so the job starts Docker Engine inside an Ubuntu WSL 2 distribution (Vampire/setup-wsl) and runs the emulator there with docker run. The Windows docker CLI and lstk reach that engine through DOCKER_HOST=tcp://127.0.0.1:2375, which WSL forwards to the runner's localhost. Installing docker.io already starts a daemon on the Unix socket alone, so the job stops it and starts one that also listens on TCP, and waits on the TCP endpoint.
• As the README asks, bash drops the carriage returns Windows programs print (set -o igncr), turned on for every bash through BASH_ENV, since exporting SHELLOPTS in a step would hand the step's own -e and pipefail to the sample scripts.
• WSL's DNS tunneling is turned off: with it, the containers of the Docker Engine in WSL could not reach WSL's resolver, and the Container Apps runtime could not pull images; without it, WSL hands out the NAT device on the host as the DNS server, which containers reach too.
• lstk 1.4.0 cannot register its Azure CLI cloud on Windows when the CLI sits under C:\Program Files: it passes the cloud configuration's JSON to az.cmd, and cmd.exe cuts that command line at the space ('C:\Program' is not recognized). A junction without spaces, first on the PATH, works around it until lstk passes the JSON another way.
• The tools the samples need and the Windows image lacks or keeps off the PATH: the zip MSYS2 ships, psql from the image's PostgreSQL, the Go sqlcmd release pinned with its SHA-256, and Java 25 for the Service Bus sample. A step prints their versions.

Tests

• actionlint with shellcheck on the workflow and on each bash step, and the repository's pre-commit hooks (zizmor, gitleaks).
• The first manual runs stopped before any sample ran and found four Windows problems: Git for Windows refused the empty file named ..., and Maven's mvn launcher needs the path conversion (both fixed in Run the scripts from Git Bash and MSYS2 on Windows #141); the Docker daemon the package started (fixed here); and the lstk cloud registration above (worked around here).
• This manual run runs every sample with all of them fixed.

Related

• The AKS samples get the same job: Run all samples on a Windows runner from Git Bash localstack-samples/aks-samples#48

🤖 Generated with Claude Code

https://claude.ai/code/session_01DhZ2ojsEXd2SGMo7s9uiZh

[Copilot]

🟡 Changes recommended

Unhandled CRLF output from native Windows tools causes deterministic failures in sample comparisons and numeric checks.

2 open issues

• Normalize CRLF output before Bash and Python validation · New
• Windows matrix runs all cases instead of the stated seven · New

What changed in this PR

Adds an on-demand Windows CI path to exercise the sample suite from Git Bash with MSYS_NO_PATHCONV=1, complementing the Windows compatibility changes in #141.

Changes:

• Adds a manual windows input that selects the full amd64 sample matrix instead of Linux jobs.
• Runs Docker Engine and the LocalStack emulator inside WSL 2, accessible from Windows tools.
• Installs sample prerequisites and adds retry handling and diagnostic logs.

File	Description
.github/​workflows/​run-samples.yml	Adds Windows dispatch routing, WSL-backed emulator setup, tooling, sample execution and retries.

_{Review effort: Balanced}

[DrisDary]

Thanks @paolosalvatori windows makes sence