Migrate from the localstack CLI to lstk - #28
Open
HarshCasper wants to merge 2 commits into
Open
Conversation
| # Disabled: `lstk aws`/`lstk cdk` (used via the Makefile targets that preview-cmd | ||
| # below calls) always target their own locally-managed emulator and ignore | ||
| # AWS_ENDPOINT_URL, so they can't reach the remote ephemeral instance this | ||
| # workflow provisions. Re-enable once that's resolved. |
There was a problem hiding this comment.
This is already resolved, although the lstk docs haven't been updated to reflect that AWS_ENDPOINT_URL is now recognized.
| state-backend: ephemeral | ||
| state-action: start | ||
| include-preview: 'true' | ||
| # TODO(lstk): no install-lstk equivalent in the setup-localstack action yet — |
There was a problem hiding this comment.
What is the intention of this TODO? lstk aws is already part of lstk, so all that's required is for aws to be installed.
| ``` | ||
|
|
||
| The `EXTRA_CORS_ALLOWED_ORIGINS` configuration variable allows our website to send requests to the HTTP APIs exposed via the API Gateway. If you prefer running LocalStack in detached mode, you can add the `-d` flag to the `localstack start` command, and use Docker Desktop to view the logs. | ||
| The `EXTRA_CORS_ALLOWED_ORIGINS` configuration variable allows our website to send requests to the HTTP APIs exposed via the API Gateway. If you prefer running LocalStack in detached mode, you can add the `--non-interactive` flag to the `lstk start` command, and use Docker Desktop to view the logs. |
There was a problem hiding this comment.
Not correct, since lstk always run in a detached mode, and not just when --non-interactive is used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
localstack/awslocal/cdklocalinvocations withlstkacross the Makefile, README, npm scripts, and CI workflows.setup-localstackaction in the main CI workflow withnpm install -g @localstack/lstk+lstk start.lstkyet (same treatment as the quiz app).tflocalinstall step; this repo has no Terraform.Testing
Part of DEVX-1056