Repository navigation
Add CI that tests the dog API through both RDS proxies - #3
Merged
Merged
Conversation
Set DB_PORT for put-dog, raise Lambda timeouts for Java cold starts, make db-setup re-runnable, and add make build/init-db/test. Claude-Session: https://claude.ai/code/session_01DZfDmzUBPqNAu3yFKyfCNM
LocalStack returns the proxy endpoint without a port, so JDBC fell back to 5432. Pass the cluster port, which matches the proxy port on AWS, and use it in the put-dog JDBC URL. Claude-Session: https://claude.ai/code/session_01DZfDmzUBPqNAu3yFKyfCNM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repo had no CI, and its integration test file was empty.
Sample fixes:
localhost.localstack.cloudand serves the database on the cluster port (4510), so every connection failed. Terraform now passes the cluster port, which on AWS is also the proxy port:HOSTisendpoint:portfor the secret auth functions.put-dogreadsDB_PORTto sign the IAM auth token, but Terraform never set it, so the function failed on init. Terraform now sets it, and the put-dog JDBC URL uses it.get-dog,delete-doganddb-setupused the 3s default timeout, too short for a Java cold start plus a JDBC handshake. All functions now use 30s and 512 MB.db-setupfailed on a second run becauseCREATE USER token_useralready existed. It now skips the user if present.Test:
test.sh:db-setupmake build,make init-dbandmake testtargets. The README uses them.make deployandmake test.Verified by CI.
https://claude.ai/code/session_01DZfDmzUBPqNAu3yFKyfCNM