fix: register workers with matching address in launch_all_serve - #3919
Open
Chessing234 wants to merge 1 commit into
Open
fix: register workers with matching address in launch_all_serve#3919Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
model_worker uses --worker-address independently of --host/--port. launch_all_serve only forwarded host/port from model-path-address, so workers listening on custom ports still registered as localhost:21002. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
launch_all_serveforwarded--host/--portfrommodel-path@host@portbut never set--worker-address.model_workerregisters with the controller using--worker-address(defaulthttp://localhost:21002), so custom ports (including the script default@20002) left the controller pointing at the wrong address.http://{host}:{port}as--worker-addressfor each launched worker.Test plan
model-path@localhost@20002now emits--port 20002and--worker-address http://localhost:20002python3 -m py_compile fastchat/serve/launch_all_serve.pypython -m fastchat.serve.launch_all_serve --model-path-address "MODEL@localhost@2021"and confirm controller listshttp://localhost:2021Made with Cursor