fix: pin QR encoder to prevent WalletConnect crash - #811
Open
ECWireless wants to merge 1 commit into
Open
ECWireless wants to merge 1 commit into
ECWireless wants to merge 1 commit into
Conversation
Override cuer@0.0.3's qr dependency to 0.5.5, which supports the border: 0 option used by RainbowKit's QR renderer. Newer qr versions reject it and crash the page when opening WalletConnect. Refs #810
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Pins cuer’s QR dependency to qr@0.5.5 to prevent WalletConnect QR rendering crashes.
Changes:
- Adds a targeted pnpm override.
- Updates the lockfile to resolve
qr@0.5.5.
| File | Description |
|---|---|
pnpm-lock.yaml |
Records the pinned QR package and resolution. |
package.json |
Defines the targeted dependency override. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Override cuer@0.0.3's qr dependency to 0.5.5, which supports the border: 0 option used by RainbowKit's QR renderer. Newer qr versions reject it and crash the page when opening WalletConnect.
Refs #810
Description
Fixes the WalletConnect crash described in RainbowKit #2677 by pinning cuer’s QR encoder to qr@0.5.5; newer versions reject RainbowKit’s border: 0 option. Verified WalletConnect and Rainbow QR rendering locally, with all tests, type checks, and lint passing.
Type of Change
Related Issue(s)
Closes: #810
Changes Made
Testing
How to test (optional unless test is not trivial)
Impact / Risk
Risk level: Low
Impacted areas: Dependancies
User impact: User can now use WalletConnect
Rollback plan: Vercel rollback