Update media-sdk. Support codec parameters. - #837
Open
dennwc wants to merge 2 commits into
Open
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
dennwc
force-pushed
the
codec-params
branch
3 times, most recently
from
September 7, 2026 19:08
eac440f to
5024d0e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
dennwc
enabled auto-merge (squash)
September 8, 2026 11:12
* Match DTMF sample rate to the audio codec rate. * Skip opus tests for now.
There was a problem hiding this comment.
Devin Review found 1 new potential issue.
2 flags not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)
|
|
||
| func (w *inboundDTMFWriter) SampleRate() int { | ||
| return dtmf.SampleRate | ||
| return 0 |
There was a problem hiding this comment.
🔴 PIN calls panic after verification
A PIN-protected call locks the DTMF switch to the negotiated rate through pinDTMFWriter. joinRoom then swaps in inboundDTMFWriter with zero rate, causing WriteCloserSwitch.Swap to panic.
Prompt for agents
PIN-protected inbound calls attach pinDTMFWriter with the negotiated DTMF clock rate in inboundCall.pinPrompt. After a valid PIN, inboundCall.joinRoom replaces that writer with Room.GetInboundDTMFWriter. inboundDTMFWriter.SampleRate currently returns zero. media-sdk WriteCloserSwitch locks its rate from the first writer and panics when a later writer has another rate, so this transition panics. Preserve the negotiated DTMF rate across the handoff, or redesign this event-only switch so both writers expose one consistent rate. Add a successful PIN-call test that reaches joinRoom.
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.