Skip to content

Update go deps (major) #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update go deps (major) #834

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ require (
github.com/livekit/psrpc v0.7.6
github.com/livekit/server-sdk-go/v2 v2.18.2-0.20260821165736-9b5928e4fcb8
github.com/livekit/sipgo v0.13.2-0.20260916140745-9a614a00b141
github.com/mjibson/go-dsp v0.0.0-20180508042940-11479a337f12
github.com/ory/dockertest/v3 v3.12.0
github.com/pion/rtp v1.10.5
github.com/mjibson/go-dsp v1.0.0

@devin-ai-integration devin-ai-integration Bot Sep 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 DSP upgrade blocks every build

Requiring github.com/mjibson/go-dsp at v1.0.0 makes every Go command fail. The release declares its module path as github.com/madelynnblue/go-dsp.

Learn more

Go validates that a required module path matches the module directive in the downloaded release. The v1.0.0 archive is available under github.com/mjibson/go-dsp, but its go.mod declares github.com/madelynnblue/go-dsp. Resolution stops before compilation, including during the Docker image's go mod download step.

Example: Running go mod download fails with module declares its path as: github.com/madelynnblue/go-dsp but was required as: github.com/mjibson/go-dsp. No SIP binary or test package can then build.

Recommended fix: Revert to the prior pseudo-version, or migrate the requirement and FFT import to github.com/madelynnblue/go-dsp after validating the ownership change and updating go.sum.

Suggested change
github.com/mjibson/go-dsp v1.0.0
github.com/mjibson/go-dsp v0.0.0-20180508042940-11479a337f12
Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

github.com/ory/dockertest/v4 v4.0.0
github.com/pion/rtp/v2 v2.0.0
Comment on lines +19 to +20

@devin-ai-integration devin-ai-integration Bot Sep 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Major upgrades never reach consumers

Declaring dockertest/v4 and rtp/v2 leaves every consumer on the old module paths. RTP handling remains on version 1, while integration tests still require dockertest/v3.

Prompt for agents 
Complete both major-version migrations. Update all github.com/pion/rtp imports in pkg/media/rtpconn/conn.go, pkg/sip/media.go, and pkg/sip/media_pipeline_test.go to github.com/pion/rtp/v2, adapting API changes as needed. Update all github.com/ory/dockertest/v3 imports under test/integration to github.com/ory/dockertest/v4, including the docker subpackage, and adapt the v4 API. Then regenerate go.mod and go.sum so the old modules are removed and the new modules are actually selected.
Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

github.com/pion/sdp/v3 v3.0.19
github.com/pion/webrtc/v4 v4.2.18
github.com/prometheus/client_golang v1.24.1
Expand Down
Loading