Add pre-encoded video ingest FFI - #1418
Open
stephen-derosa wants to merge 1 commit into
Open
Conversation
Contributor
Changeset ✓This PR includes a changeset covering all affected packages:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
stephen-derosa
force-pushed
the
sderosa/pre-encoded-ingest
branch
from
September 9, 2026 18:29
3b9d40a to
843f87f
Compare
stephen-derosa
force-pushed
the
sderosa/pre-encoded-ingest
branch
from
September 9, 2026 19:48
72ab978 to
5bebd80
Compare
ladvoc
approved these changes
Sep 10, 2026
| }, | ||
| }; | ||
|
|
||
| const MAX_ENCODED_VIDEO_FRAME_SIZE: usize = 64 * 1024 * 1024; |
Contributor
There was a problem hiding this comment.
question: Where does this value come from?
| /// | ||
| /// `capture.data_ptr` must address `capture.data_len` readable bytes for | ||
| /// the duration of this call. | ||
| pub unsafe fn capture_encoded_frame( |
Contributor
There was a problem hiding this comment.
suggestion: Instead of marking this whole function unsafe, consider doing this instead:
- In the protobuf, encapsulate pointer/length fields in their own message
- Create unsafe helper method to convert this to Rust slice
- Use this in
capture_encoded_frame
This keeps unsafe code scoped and auditable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Expose Pre-Encoded Ingest through ffi