Re-baseline the uniffi iOS and Android size budgets - #1414
Merged
Merged
Conversation
Contributor
Changeset ✓This PR includes a changeset covering all affected packages:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
The livekit-uniffi 0.1.10 release failed both size gates. Data streams v2 (#1286) bumped only ANDROID_SIZE_LIMIT_BYTES, leaving the iOS budget at 1152 KiB while the same async foreign-trait machinery landed in that slice too, so it measured 1433 KiB. Android was a separate, ordinary 8 KiB of creep past its 1536 KiB limit at 1544 KiB. Both limits are re-baselined on the measured 0.1.10 sizes with 10% headroom, rounded up to a 64 KiB boundary. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
pblazej
force-pushed
the
blaze/bump-uniffi-size
branch
from
September 9, 2026 07:05
18bd072 to
31ecd85
Compare
davidliu
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
livekit-uniffi0.1.10 release failed both size gates (run):ios-arm64framework binary)arm64-v8a.so)These are two different failures.
iOS had a stale budget. Data streams v2 (#1286) measured the arm64-v8a slice and bumped
ANDROID_SIZE_LIMIT_BYTESfrom 1280 KiB to 1536 KiB, but leftSPM_SIZE_LIMIT_BYTESuntouched at 1152 KiB. The same async foreign-trait machinery landed in the iOS slice too — Android's new budget absorbed it and iOS's did not, so the iOS limit had been a week stale by the time the release cut. The 281 KiB overage is that change arriving against an unbumped budget, not a new regression.Android was ordinary creep, missing by 8 KiB.
Both limits are now re-baselined on the measured 0.1.10 sizes with 10% headroom, rounded up to a 64 KiB boundary, and each comment records the measurement it came from so the next bump has a baseline to reason from.
Worth a follow-up
The reason a forgotten bump stayed invisible for a week is that these gates only ever run at release time:
uniffi-packages.ymltriggers onrelease: [published]/workflow_dispatch, anduniffi-swift.yml/uniffi-android.ymlareworkflow_call-only. No PR executesswift-check-size, so a stale budget surfaces only once a release tag is already cut. Moving the gates earlier isn't free — it means building the xcframework and AAR on PRs touchinglivekit-uniffi(~8 min each in the release run), so it wants a path filter rather than running repo-wide. Left out of this patch deliberately.