Skip to content

refactor(signaling): explicit signal lifecycle state machine #1402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukasIO wants to merge 6 commits into
base: main
Choose a base branch
from
Open

refactor(signaling): explicit signal lifecycle state machine #1402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5849a53
refactor(signaling): explicit signal lifecycle state machine
lukasIO Sep 4, 2026
b54039a
Merge branch 'main' into lukas/signal-state-machine
lukasIO Sep 4, 2026
2dca7fd
Create refactor_signaling_explicit_signal_lifecycle_state_machine.md
lukasIO Sep 7, 2026
dd0c292
Merge branch 'main' into lukas/signal-state-machine
lukasIO Sep 7, 2026
92a3413
Merge branch 'lukas/signal-state-machine' of https://github.com/livek…
lukasIO Sep 7, 2026
aa272e6
clarify naming
lukasIO Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/refactor_signaling_explicit_signal_lifecycle_state_machine.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
livekit: patch
livekit-api: patch
livekit-ffi: patch
---

refactor(signaling): explicit signal lifecycle state machine - #1402 (@lukasIO)
16 changes: 16 additions & 0 deletions .changeset/signal_state_enum.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
---
livekit-signaling: patch
---

# Model the signal connection lifecycle as an explicit state machine

`SignalInner` tracked its lifecycle in two fields, a stream slot and a `reconnecting` flag,
that had to be kept in step by hand. It now holds one `SignalState` that owns the transport
(`Connected`, `Reconnecting`, `Offline`, `Disconnecting`, `Closed`). Every change goes through one
Comment on lines +1 to +9

@1egoman 1egoman Sep 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: this file and .changeset/refactor_signaling_explicit_signal_lifecycle_state_machine.md look to be semantically identical?

transition table, and an input a state does not accept is logged and refused. A resume
started from a state that cannot accept it now fails with `SignalError::InvalidState`
instead of proceeding.

The held-signal queue moved to a sync lock that is never held across an await, which removes
a lock-order hazard between the queue and the stream lock. A send that fails for any
transport error is now held like a `SendError` was.
Loading
Loading