Fix Objective-C linking - #1394
Open
ladvoc wants to merge 3 commits into
Open
Conversation
Contributor
No changeset foundThis PR modifies versioned packages but doesn't include a changeset. The following packages require a version bump:
A package must be bumped when its own files change, and whenever a package it depends on is bumped (so downstream consumers get a matching release). Click here to create a changeset for the missing packages The link pre-populates a changeset file with If this change doesn't require a version bump, add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ObjC categories in libwebrtc.a (e.g.
NSString (StdString)) export no symbols, so the linker drops them and macOS/iOS binaries abort at startup:The usual fix,
-ObjC(currently documented in the README as required for consumers), can't be applied at the crate level since Cargo doesn't propagate link args to dependent crates. Instead, merge allobj/sdkobjects into one archive member when assembling libwebrtc.a, so the categories load together with the referenced SDK symbols and consumers need no flag as of the next prebuilt release.After this merges, livekit-examples/rust-dev-client should be updated to remove the workaround.