Skip to content

Fix Objective-C linking - #1394

Open
ladvoc wants to merge 3 commits into
mainfrom
ladvoc/fix-objc-linking
Open

Fix Objective-C linking#1394
ladvoc wants to merge 3 commits into
mainfrom
ladvoc/fix-objc-linking

Conversation

@ladvoc

@ladvoc ladvoc commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

The ObjC categories in libwebrtc.a (e.g. NSString (StdString)) export no symbols, so the linker drops them and macOS/iOS binaries abort at startup:

+[NSString stringForStdString:]: unrecognized selector sent to class

The usual fix, -ObjC (currently documented in the README as required for consumers), can't be applied at the crate level since Cargo doesn't propagate link args to dependent crates. Instead, merge all obj/sdk objects into one archive member when assembling libwebrtc.a, so the categories load together with the referenced SDK symbols and consumers need no flag as of the next prebuilt release.

After this merges, livekit-examples/rust-dev-client should be updated to remove the workaround.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

No changeset found

This PR modifies versioned packages but doesn't include a changeset. The following packages require a version bump:

  • libwebrtc
  • livekit
  • livekit-ffi
  • webrtc-sys

A package must be bumped when its own files change, and whenever a package it depends on is bumped (so downstream consumers get a matching release).

Click here to create a changeset for the missing packages

The link pre-populates a changeset file with patch bumps for the missing packages. You can also add them to your existing changeset. Edit the bump types as needed before committing.

If this change doesn't require a version bump, add the internal label to this PR.

devin-ai-integration[bot]

This comment was marked as resolved.

@ladvoc
ladvoc requested a review from pblazej September 2, 2026 19:21

@pblazej pblazej left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants