Skip to content

ipc: add room_id to the job logger and bind it as the process logger - #2485

Merged
andrewnitu merged 3 commits into
mainfrom
andrewnitu/room-id-job-logger
Sep 14, 2026
Merged

ipc: add room_id to the job logger and bind it as the process logger#2485
andrewnitu merged 3 commits into
mainfrom
andrewnitu/room-id-job-logger

Conversation

@andrewnitu

Copy link
Copy Markdown
Contributor

No description provided.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 231a4cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@andrewnitu
andrewnitu force-pushed the andrewnitu/room-id-job-logger branch from c732368 to 09a047c Compare September 14, 2026 16:31
jobID: msg.value.runningJob.job.id,
room_id: msg.value.runningJob.job.room?.sid,
});
setLoggerState(logger, loggerOptions()!);

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line is needed to update the global logger, i.e. whenever log() is called.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@andrewnitu
andrewnitu marked this pull request as ready for review September 14, 2026 19:10
@andrewnitu
andrewnitu requested a review from a team as a code owner September 14, 2026 19:10

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@andrewnitu
andrewnitu merged commit 6acfb83 into main Sep 14, 2026
9 of 11 checks passed
@andrewnitu
andrewnitu deleted the andrewnitu/room-id-job-logger branch September 14, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants