Skip to content

chore: remove unused oaiBuildFunctionInfo helper - #2441

Open
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-unused-oaibuildfunctioninfo-helper-974f0b
Open

chore: remove unused oaiBuildFunctionInfo helper#2441
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-unused-oaibuildfunctioninfo-helper-974f0b

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Description

Removes the unused oaiBuildFunctionInfo helper from agents/src/llm/utils.ts and its re-export from the llm namespace. Also drops the now-unused value import of FunctionCall (kept as a type-only import).

Changes Made

  • Removed the oaiBuildFunctionInfo function from agents/src/llm/utils.ts.
  • Removed the oaiBuildFunctionInfo re-export from agents/src/llm/index.ts.
  • Changed the FunctionCall import in agents/src/llm/utils.ts to type-only (its only remaining use is a type annotation on executeToolCall's parameter).
  • Regenerated agents/etc/agents.api.md via pnpm api:update.

Pre-Review Checklist

  • Build passes: typecheck, build, lint, and api:check all pass locally.
  • AI-generated code reviewed.
  • Changes explained: see below.
  • Scope appropriate: all changes relate to removing this one symbol.
  • Video demo: not applicable — no runtime behavior change.

Testing

  • Automated tests added/updated: not applicable — pure removal with no behavior change.
  • All tests pass: pnpm vitest run agents/src/llm/utils.test.ts agents/src/llm/tool_context.test.ts (130 passed).
  • restaurant_agent.ts and realtime_agent.ts: not applicable — no runtime behavior change.

Additional Notes

oaiBuildFunctionInfo had zero callers anywhere in the repo — no production code, no tests, no plugins — making it a stale leftover utility. The neighboring oaiParams and OpenAIFunctionParameters were deliberately kept: oaiParams is exercised by tests (removing it would require deleting test consumers), and OpenAIFunctionParameters is a publicly-exported type (no @internal tag) used as oaiParams' return type.

History


Dead Code PRs can be configured here.

@detail-app
detail-app Bot requested a review from a team as a code owner September 8, 2026 06:00
@changeset-bot

changeset-bot Bot commented Sep 8, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 61f3767

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants