chore: remove unused oaiBuildFunctionInfo helper - #2441
Open
detail-app[bot] wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the unused
oaiBuildFunctionInfohelper fromagents/src/llm/utils.tsand its re-export from thellmnamespace. Also drops the now-unused value import ofFunctionCall(kept as a type-only import).Changes Made
oaiBuildFunctionInfofunction fromagents/src/llm/utils.ts.oaiBuildFunctionInfore-export fromagents/src/llm/index.ts.FunctionCallimport inagents/src/llm/utils.tsto type-only (its only remaining use is a type annotation onexecuteToolCall's parameter).agents/etc/agents.api.mdviapnpm api:update.Pre-Review Checklist
api:checkall pass locally.Testing
pnpm vitest run agents/src/llm/utils.test.ts agents/src/llm/tool_context.test.ts(130 passed).restaurant_agent.tsandrealtime_agent.ts: not applicable — no runtime behavior change.Additional Notes
oaiBuildFunctionInfohad zero callers anywhere in the repo — no production code, no tests, no plugins — making it a stale leftover utility. The neighboringoaiParamsandOpenAIFunctionParameterswere deliberately kept:oaiParamsis exercised by tests (removing it would require deleting test consumers), andOpenAIFunctionParametersis a publicly-exported type (no@internaltag) used asoaiParams' return type.History
Dead Code PRs can be configured here.