Repository navigation
ci: name the Legacy files so they come last on the release page - #205
Merged
Merged
Conversation
GitHub lists a release's files by name: ConsoleMode-Legacy-* came before the current version's. ConsoleModeLegacy-* sorts after every ConsoleMode-* name and still matches neither the update check nor winget. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Legacy release asset names — Updated the legacy executable names and matching artifact, workflow, and release-note references so those assets sort after the current downloads without matching updater or winget naming patterns.
- Documentation and changelogs — Updated the 1.7.0 Legacy download names in both changelogs, the English and Portuguese release guides, the PRD, and the manual test checklist.
gpt-6-luna ｜ 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The owner wants the Legacy downloads listed below the current version's on the release page. GitHub lists a release's files by name and has no manual order, and
ConsoleMode-Legacy-*sorted first (L<P<S).ConsoleModeLegacy-Setup-x64.exe/ConsoleModeLegacy-Portable-x64.exe:ConsoleModefollowed by a letter sorts after everyConsoleMode-…name (-is 0x2D,L0x4C, case-sensitive or not), so the page reads Portable, Setup, Legacy Portable, Legacy Setup. They still don't start withConsoleMode-Setup/ConsoleMode-Portable(the update check's prefixes) nor match winget'sConsoleMode-Setup-x64\.exe$.Renamed everywhere the names appear:
release.yml(rename step, artifact, attach list, notes), both changelogs' 1.7.0 Legacy item, the release paragraph of both guides, PRD D-27,docs/TESTING.md. The current 1.7.0 draft is rebuilt after this merges, so its files and notes carry the new names.🤖 Generated with Claude Code