Repository navigation
fix: keep the settings this version doesn't know when saving - #201
Merged
Merged
Conversation
config.json is shared with the Legacy build (1.6.2's interfaces, published next to 1.7.0), which has two settings this version dropped (uiMode, tourDone). Saving used to discard them, so going back to Legacy showed its tour again and forgot the interface picked there. AppConfig now keeps unknown members (JsonExtensionData) and BuildConfig hands them back. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
The PR preserves unknown config properties when the current app rebuilds and saves AppConfig, covering Legacy-only and future settings.
- Forward-compatible config data — Adds JSON extension data to
AppConfigand carries it throughMainViewModel.BuildConfig. - Regression coverage and release notes — Tests the deserialize/update/serialize round trip and documents the behavior in both changelogs.
gpt-6-luna ｜ 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
1.7.0 will ship with a Legacy download (Console Mode 1.6.2's interfaces, built from
release/1.7-legacy, #200) that sharesconfig.jsonwith this version. #200 makes Legacy keep the settings only 1.7 has; this is the other half: 1.7 keeps the two settings only Legacy has (uiMode,tourDone) instead of dropping them on save, so going 1.7 → Legacy → 1.7 → Legacy never shows Legacy's tour again or forgets the interface picked there. It also covers settings a future version adds.AppConfig.OtherSettings([JsonExtensionData]), carried over inBuildConfig.AppConfigTests; changelogs.Verified on the owner's PC (debug build, portable data, no session started)
The config Legacy saved in #200's test (52 keys,
uiMode: desktop,tourDone: true) opened in this build; How to turn off other displays changed with the keyboard so the app saved: 52 keys out, none lost,uiModeandtourDoneintact, the custom apps identical,hideStrategychanged as picked.dotnet test: 677 passing.🤖 Generated with Claude Code