docs: fix parameter names left from the nautilus era - #3832
Merged
Conversation
mtwebster
reviewed
Sep 7, 2026
| * with a component. This is normally called only by subclasses. | ||
| * @view: FMDirectoryView in question. | ||
| * @parent_window: The window to parent dialogs on. | ||
| * @files: A GList of NemoFiles to activate. |
Member
There was a problem hiding this comment.
This doesn't really 'fix' anything - all arguments should be listed...
parent_window
files
launch_directory
flags
user_confirmation
Contributor
Author
There was a problem hiding this comment.
Added documentation for every parameter, including slot, in signature order in eee6903. Also moved the parameter descriptions before the function description.
mtwebster
reviewed
Sep 7, 2026
Comment on lines
+2317
to
+2321
| * Activate a file in this view. This might involve switching the displayed | ||
| * location for the current window, or launching an application. | ||
| * @view: FMDirectoryView in question. | ||
| * @parent_window: The window to parent dialogs on. | ||
| * @file: A NemoFile representing the file in this view to activate. | ||
| * @use_new_window: Should this item be opened in a new window? | ||
| * @flags: How the location should be opened. |
Contributor
Author
There was a problem hiding this comment.
Updated this function too in eee6903: all five parameters are documented. Verified that both parameter lists match the signatures and that executable code is unchanged.
Signed-off-by: Dmitry Rantovov <rantovov5@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These names date back to nautilus:
nemo_mime_activate_filestill documents@viewand@use_new_window, which becameparent_windowandflagswhen the window slot work landed, andnemo_launch_applicationdocuments@urisalthough it takes a list of files and builds the uris itself. I left the block abovenemo_launch_application_from_command_arrayalone, since it names the non-array function and moving it is a judgement call.