sound applet: show input device selector when multiple inputs are connected - #13977
Open
MDHasan0078 wants to merge 1 commit into
Open
sound applet: show input device selector when multiple inputs are connected#13977MDHasan0078 wants to merge 1 commit into
MDHasan0078 wants to merge 1 commit into
Conversation
…nected The input section was only visible when a recording app was active. This meant users couldn't switch input devices (e.g. mic vs earphones) without opening Sound Settings first. Now it shows up whenever 2+ input devices are detected, same as the output device selector.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Input deviceselector in the sound applet was only visible when a recording app was actively using the microphone. Users with multiple input devices (e.g. built-in mic + earphones) had no way to switch between them unless a recording app happened to be running, or they opened Sound Settings first (which incidentally triggered the section to appear).Fix
Show
_inputSectionas soon as 2+ input devices are detected in_onDeviceAdded, mirroring the existing behavior for output devices. Hide it again in_onDeviceRemovedwhen input devices drop back to one and nothing is recording.