wacom: Use the GDK Wayland device node path on Wayland - #473
Open
ArekMiszcz wants to merge 1 commit into
Open
ArekMiszcz wants to merge 1 commit into
ArekMiszcz wants to merge 1 commit into
Conversation
get_device_path() always went through xdevice_get_device_node() and gdk_x11_device_get_id(). The wacom plugin does not force the X11 GDK backend, so on Wayland this treats a Wayland GdkDisplay as an X11 Display and csd-wacom segfaults in XInternAtom as soon as a tablet is present. Use gdk_wayland_device_get_node_path() for Wayland devices, do not hand a NULL path to libwacom, and free the path, which was leaked. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In a Cinnamon Wayland session with a tablet connected (Wacom Intuos S 2 here), csd-wacom segfaults right after every login, and cinnamon-session gives up respawning it:
Cause
The wacom plugin does not force the X11 GDK backend, so on Wayland its
GdkDevices are Wayland devices.get_device_path()still goes throughgdk_x11_device_get_id()andxdevice_get_device_node(), which use the WaylandGdkDisplayas an X11Display.Fix
gdk_wayland_device_get_node_path().is_opaque_tablet(), do not pass a NULL path to libwacom, and free the path afterwards (it was leaked).The X11 code path is unchanged.
Testing
org.cinnamon.SettingsDaemon.Wacom. Before, it crashed within a second of starting.🤖 Generated with Claude Code