Conversation
The exported Percentage property previously changed to whichever present UPower device first differed from the last value. A peripheral notification could therefore make it alternate between the system battery and the peripheral charge level. Scan every device before publishing a value. Prefer a present battery, fall back to a UPS, and ignore peripheral devices while preserving composite battery handling. Add focused GLib coverage for peripheral exclusion and UPS fallback.
shivamklr
marked this pull request as ready for review
September 4, 2026 17:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
engine_recalculate_state_percentage()compares each present UPower device with one shared previous percentage. With a system battery and Bluetooth peripheral, this can alternate the exportedPercentageand continuously emitPropertiesChanged.Select one percentage per recalculation: prefer a present system battery, fall back to a UPS, and ignore peripheral batteries. Composite battery handling is unchanged.
On the test system, a same-source 6.6.4 A/B validation (12 runs per variant and hardware state, 30 seconds each) reduced the AC plugged + Bluetooth connected case from 188.7 to 0 outgoing messages per observation,
csd-powerCPU from 0.336% to 0.044% of one core, and context switches from 10.47 to 0.75/s. Thepower-stateregression test passes.Fixes #455