test: discover development routes in the shared schema suite

[epipav]

Why

The cross-route suite in api/tests/common-schemas.test.ts ran off literal route lists (seriesRoutes, rangeRoutes, and an integer-summary table). A new endpoint that nobody added to those lists silently skipped the shared granularity wording check, the inclusive-start / exclusive-end bounds check, and the unit check. None of the five batch-2 endpoints (#2247, #2245, #2244, #2243, #2246) is in the lists. Raised by @themarolt on #2243. Adding each route in its own PR would put five edits on the same lines of one shared test, the conflict pattern #2241 removed for route registration.

What

The suite now reads the development routes from the served /v1-alpha/openapi.json:

• every development route must take the common range and document the inclusive start and exclusive end
• every route with a granularity parameter must mark it required, use the shared enum, and carry Granularity.description
• every response property shaped like a period summary (current, previous, percentageChange, changeValue), whatever its name, must state a unit on the three values and keep percentageChange a nullable number. Integer counts must say (count ...); numbers must say (seconds), (percent) or (percentage points). The unit may be followed by a sentence, so nullable notes (merge-lead-time) pass.
• a guard asserts at least five routes, at least one series route and at least one summary were discovered

The module side is already pinned by tests/v1-alpha-autoload.test.ts (filename = path leaf), so between the two, a development module cannot be served without being checked.

Verification

• On main: 61 tests in the file, full api suite green, lint, tsc-check, format:check green.
• Against each open batch-2 branch (test file copied in, run, restored): merge-lead-time 67, review-time-by-pr-size 62, code-review-participants 63, review-comments 64, code-reviews 64, all green. So no open PR goes red when this merges, and each gets the checks it was missing.

Jira: IN-1349

[Copilot]

Copilot review overview

🟡 Changes recommended

Referenced OpenAPI schemas can bypass the new summary validation.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1

Open (1)

• Resolve schema references before inspecting response properties · New

What changed in this PR

Updates shared schema tests to automatically cover all development routes exposed by the v1-alpha OpenAPI specification.

Changes:

• Discovers development, series, and summary routes dynamically.
• Validates shared ranges, granularity, units, and summary types.

File	Description
api/​tests/​common-schemas.test.ts	Replaces static route lists with OpenAPI-based discovery and validation.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[themarolt]

lgtm - one question on moving the spec fetch to module scope

[Copilot]

Copilot review overview

🟡 Changes recommended

The generalized assertions can still accept inconsistent units and invalid shared query schemas.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1

Open (1)

• Enforce consistent units across numeric summary fields · New

Resolved since last review (1)

• Resolve schema references before inspecting response properties

Previously missed (1)

In code that hasn't changed since last review

Validate discovered route query shape against DateRangeQuery

api/​tests/​common-schemas.test.ts:481

This verifies the date wording but not the shared query shape, so a discovered route can omit repos or make a date required or non-date while still passing. Assert that repos, startDate, and endDate are present, optional, and use the types and formats from DateRangeQuery.

[Copilot]

Copilot review overview

🟡 Changes recommended

The route discovery and numeric-unit checks contain mismatches that can reject valid future endpoints.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 2

Open (2)

• Filter development paths to routes with GET operations · New
• Accept percentage points as a numeric summary unit · New

Resolved since last review (1)

• Enforce consistent units across numeric summary fields

[themarolt]

lgtm - the status guard and the $ref resolve cover my earlier point on the module-scope fetch

[Copilot]

Copilot review overview

🟢 Approval recommended

The refactor closes the route coverage gap without introducing unresolved issues.

Review effort: Balanced
Findings: None

Resolved since last review (2)

• Accept percentage points as a numeric summary unit
• Filter development paths to routes with GET operations