Repository navigation
fix: drop shared meeting host accounts in the meetings source query - #5064
Conversation
Signed-off-by: Mouad BANI <mouad-mb@outlook.com>
PR SummaryLow Risk Overview
Reviewed by Cursor Bugbot for commit e93d6f6. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
|
There was a problem hiding this comment.
🟢 Approval recommended
The narrow change consistently reuses the existing exclusion list, with no blocking issues identified; tests were not executed.
No open issues 🎉
What changed in this PR
Moves shared meeting-host filtering into the Snowflake source query, preventing intentional exclusions from inflating skip counters and blocking S3 cleanup.
Changes:
- Reuses the transformer’s existing shared-account list in SQL.
- Excludes matching emails before export, leaving transformer behavior unchanged.
- Adds an assertion covering the query predicate.
| File | Description |
|---|---|
| services/apps/snowflake_connectors/src/integrations/meetings/meeting-attendance/buildSourceQuery.ts | Filters shared meeting accounts before export. |
| services/apps/snowflake_connectors/src/integrations/meetings/meeting-attendance/buildSourceQuery.test.ts | Verifies the exclusion predicate. |
| services/apps/snowflake_connectors/src/core/personalEmail.ts | Exports the existing shared-account list. |
Review effort: Balanced
Summary
Since #5043 the meetings transformer drops rows for the 9 shared meeting host accounts (
zoom@hyperledger.org,meetings@dpdk.organd the rest). Those drops are counted astransformSkippedCount, which trips the Metaplane monitor "[SNOWFLAKE INTEGRATIONS] Skipped activities due to invalid transformation" (expected = 0) every night, and keeps the daily S3 cleanup from deleting the affected batches since it only cleans jobs withskippedCount = 0.The first export on the new image (2026-10-21 00:20Z) had 19 such skips across 14 of 48 meetings batches, out of 511,884 transformed rows. No other source had any. Datadog shows no "Failed to transform row" warnings, so none of them are real transformation failures.
This filters the shared host accounts in the meetings source query itself, so the rows never leave Snowflake and the skip counters go back to 0.
Changes
SHARED_MEETING_ACCOUNT_EMAILSis exported fromcore/personalEmail.tsso the SQL and the transformer read the same list.buildSourceQueryaddsLOWER(TRIM(t.INVITEE_EMAIL)) NOT IN (...)next to the existing empty-email predicate, rendered from that set.cleanPersonalEmailin the transformer is unchanged. A row that still reaches it is now a genuine skip the monitor should report.Other sources are untouched: none of them produced a skip, and the listed accounts are meeting hosts.
Type of change
Related issue
Follow-up to linuxfoundation/lfx-cdp-insights-ops#853 (closed by #5043).