Skip to content

fix: retry when the llm returns work experiences as strings #5054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skwowet merged 1 commit into from
Oct 20, 2026
Merged

fix: retry when the llm returns work experiences as strings #5054

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions services/apps/members_enrichment_worker/src/activities/llm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,8 @@ export async function squashWorkExperiencesWithLLM(
Maintain all relevant data fields in the final timeline and ensure no essential information is lost.

Output Format:
Return a single array of IMemberEnrichmentDataNormalizedOrganization objects:
Return a single array of IMemberEnrichmentDataNormalizedOrganization objects.
Each element must be a JSON object, never a JSON-encoded string.

Input Example:
[
Expand Down Expand Up @@ -358,7 +359,10 @@ export async function squashWorkExperiencesWithLLM(
IMemberEnrichmentDataNormalizedOrganization[]
>(memberId, prompt)

if (!Array.isArray(res?.result)) {
if (
!Array.isArray(res?.result) ||
!res.result.every((we) => _.isPlainObject(we) && typeof we.name === 'string')
) {
const errorMessage = 'LLM returned invalid work experiences payload shape!'
svc.log.warn({ memberId, result: res?.result }, errorMessage)
throw new Error(errorMessage)
Expand Down
Loading