Skip to content

feat: add Octolens enums and mention activity type (CM-1834) - #4889

Merged
themarolt merged 1 commit into
mainfrom
feat/CM-1834-octolens-types
Oct 2, 2026
Merged

themarolt merged 1 commit into
mainfrom
feat/CM-1834-octolens-types

Conversation

@themarolt

Copy link
Copy Markdown
Contributor

Summary

Foundational types for Octolens ingestion: connector-level platform enum and the shared
mention activity type across github/twitter/linkedin.

Changes

  • PlatformType.OCTOLENS, IntegrationType.OCTOLENS
  • mention activity type for GitHub and LinkedIn (Twitter already has it)

Type of change

  • Bug fix
  • New feature
  • Refactor / cleanup
  • Performance improvement
  • Chore / dependency update
  • Documentation

JIRA ticket

https://linuxfoundation.atlassian.net/browse/CM-1834

Signed-off-by: Uroš Marolt <uros@marolt.me>
Copilot AI balanced review requested due to automatic review settings October 2, 2026 20:12
@cursor

cursor Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Type and display-metadata additions only; no runtime ingestion or auth changes in this diff.

Overview
Adds Octolens as a new PlatformType and IntegrationType, with label Octolens and a null profile URL fallback (same pattern as Git/Discourse).

Introduces a shared mention activity type for GitHub and LinkedIn: enum values, UI copy (“mentioned you on …”), sentiment scoring enabled, and engagement grid score 6 (aligned with comments on each platform). This extends the existing Twitter mention pattern for Octolens-driven mention ingestion.

Reviewed by Cursor Bugbot for commit 3e0b196. Bugbot is set up for automated code reviews on this repo. Configure here.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The enum, scoring, and activity-setting changes are complete and consistent with existing Twitter mention behavior.

Review effort: Balanced
Findings: None

What changed in this PR

Adds foundational Octolens platform/integration types and shared mention activities.

Changes:

  • Adds Octolens enums, label, and profile fallback.
  • Adds scored GitHub and LinkedIn mention activities.
  • Adds default display and sentiment settings.
File Description
services/​libs/​types/​src/​enums/​platforms.ts Adds Octolens platform and integration types.
services/​libs/​integrations/​src/​integrations/​linkedin/​types.ts Adds LinkedIn mention type.
services/​libs/​integrations/​src/​integrations/​linkedin/​grid.ts Scores LinkedIn mentions.
services/​libs/​integrations/​src/​integrations/​github/​types.ts Adds GitHub mention type.
services/​libs/​integrations/​src/​integrations/​github/​grid.ts Scores GitHub mentions.
services/​libs/​integrations/​src/​integrations/​activityTypes.ts Configures mention display and sentiment behavior.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@themarolt
themarolt requested a review from gaspergrom October 2, 2026 20:46
@themarolt
themarolt merged commit 678f0c9 into main Oct 2, 2026
16 checks passed
@themarolt
themarolt deleted the feat/CM-1834-octolens-types branch October 2, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants