Skip to content

fix: production bugs in stars_cumulative_count pipe (CM-1785) #4768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
themarolt merged 4 commits into from
Sep 25, 2026
Merged

fix: production bugs in stars_cumulative_count pipe (CM-1785) #4768

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
43a8284
fix: rename stars_cumulative_count's terminal node to avoid pipe/node…
themarolt Sep 25, 2026
eac0472
fix: cast endDate non-nullable in stars_github_bucketed lambda (CM-1785)
themarolt Sep 25, 2026
bbe2344
Merge remote-tracking branch 'origin/main' into fix/CM-1785-stars-cum…
themarolt Sep 25, 2026
7b0c981
docs: drop JIRA ticket references from stars_cumulative_count pipe de…
themarolt Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions services/libs/tinybird/pipes/stars_cumulative_count.pipe
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
DESCRIPTION >
- Cumulative (running-total) star count time series for a project or curated collection,
replacing `activities_cumulative_count.pipe` for stars only (CM-1785).
- GitHub repos: no per-user star events exist any more (CM-1419/CM-1439) - the cumulative
total is read from `repositoryStarSnapshots` (aggregate-only snapshots, CM-1437/CM-1463)
replacing `activities_cumulative_count.pipe` for stars only.
- GitHub repos: no per-user star events exist any more - the cumulative
total is read from `repositoryStarSnapshots` (aggregate-only snapshots)
instead. Same `argMax(starCount, (capturedAt, updatedAt))` snapshot pattern as
`health_score_stars.pipe`, evaluated once per bucket instead of once for a single `endDate`.
- Non-GitHub (GitLab) repos: unaffected by CM-1419, still counted from per-event `star`
- Non-GitHub (GitLab) repos: unaffected by that change, still counted from per-event `star`
activities the normal way - read directly off `activityRelations_bucket_routing` /
`activityRelations_collection_bucket_routing` (the same tables `activities_filtered.pipe`
itself routes to), filtered `platform != 'github'`, since `activities_filtered.pipe` has no
Expand All @@ -31,7 +31,7 @@ DESCRIPTION >
can swap the pipe name with no other code changes.
- **Known limitation**: a bucket earlier than a repo's first backfilled snapshot has no
snapshot to `argMax` over and reads as 0 stars for that repo, not "unknown" - undercounts
early buckets until CM-1463's backfill fully lands, never overcounts.
early buckets until the star-snapshot backfill fully lands, never overcounts.

TOKEN "insights-app-token" READ

Expand Down Expand Up @@ -178,7 +178,7 @@ SQL >
history -> coalesce(
tupleElement(
arrayFirst(
x -> tupleElement(x, 1) < ds.endDate + INTERVAL 1 DAY
x -> tupleElement(x, 1) < assumeNotNull(ds.endDate) + INTERVAL 1 DAY
{% if defined(endDate) %}
AND tupleElement(x, 1)
<= {{
Expand Down Expand Up @@ -340,7 +340,7 @@ SQL >
{% else %} SELECT toDate(now()) AS startDate, toDate(now()) AS endDate, 0 AS gitlabCumulativeStars
{% end %}

NODE stars_cumulative_count
NODE stars_cumulative_count_final
SQL >
%
{% if defined(granularity) %}
Expand Down
Loading