Skip to content

fix(tabbar): disable scroll buttons in tab bar #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepin-bot merged 1 commit into from
Sep 1, 2026
Merged

fix(tabbar): disable scroll buttons in tab bar #556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/controls/tabbar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ Tabbar::Tabbar(QWidget *parent)
setMovable(true);
setTabsClosable(true);
setVisibleAddButton(true);
setUsesScrollButtons(false);

@sourcery-ai sourcery-ai Bot Sep 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (broader_impact): When the tab count exceeds the available width, Tabbar::tabSizeHint enforces a minimum tab width of 110 pixels, so all tabs cannot fit. Disabling scroll buttons removes DTabBar's overflow navigation, causing tabs beyond the viewport to be clipped and impossible to select by clicking.

Triggers: When enough tabs are open that their combined minimum width exceeds the tab bar width.

Suggested fix: Keep an overflow navigation mechanism, such as the scroll buttons or an overflow menu, or revise the tab sizing/layout so every tab remains reachable without scrolling.

Suggested change
setUsesScrollButtons(false);
setUsesScrollButtons(true);

setDragable(true);
setAcceptDrops(true);
// setStartDragDistance(40);
Expand Down
Loading