Repository navigation
fix: add AccessibleName for AT-SPI accessibility controls - #555
deepin-bot[bot] merged 1 commit into
Conversation
|
Skipping CI for Draft Pull Request. |
Reviewer's GuideUIName the compression-page controls and the inputs and options on the compression-settings page for AT-SPI access.
Name the extraction path and action controls for AT-SPI access.
Name the file-selection control on the home page for AT-SPI access.
Name the progress bar and pause, continue, and cancel controls for AT-SPI access.
Name the back and view-file controls on the success page for AT-SPI access.
Name the retry and back controls on the failure page for AT-SPI access.
Name the archive-format radio buttons, password controls, and rename field in the dialogs for AT-SPI access.
Name the selection and recommendation controls in the settings dialog for AT-SPI access.
Name the progress dialog bar for AT-SPI access.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
d80da30 to
5d04020
Compare
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="src/source/page/compresssettingpage.cpp" line_range="305-316" />
<code_context>
m_pCompressBtn->setMinimumWidth(340); // 设置压缩按钮最小尺寸
+ // 设置无障碍名称
+ m_pFileNameEdt->setAccessibleName("FileNameEdit");
+ m_pSavePathEdt->setAccessibleName("SavePathEdit");
+ m_pCompressLevelCmb->setAccessibleName("CompressLevelComboBox");
+ m_pAdvancedBtn->setAccessibleName("AdvancedOptionsSwitch");
+ m_pPasswordEdt->setAccessibleName("PasswordEdit");
+ m_pCpuCmb->setAccessibleName("CpuThreadComboBox");
+ m_pListEncryptionBtn->setAccessibleName("ListEncryptionSwitch");
+ m_pSplitCkb->setAccessibleName("SplitCheckBox");
+ m_pSplitValueEdt->setAccessibleName("SplitValueEdit");
+ m_pCommentEdt->setAccessibleName("CommentEdit");
+ m_pCompressBtn->setAccessibleName("CompressButton");
+
// 左侧布局
QHBoxLayout *pTypeLayout = new QHBoxLayout; // 类型布局
</code_context>
<issue_to_address>
**Screen readers announce internal identifiers**
When assistive technology reads one of the newly named controls, qt exposes these explicit accessible names to AT-SPI instead of the controls’ visible text, so screen readers announce code-like strings such as “CompressButton” or “CancelButton” rather than useful, localized labels. Users relying on assistive technology cannot readily identify the controls.
Use translated, user-facing accessible names (or leave the accessible name unset when the visible text is already suitable), and keep stable automation identifiers separate from the accessible name.
Also at `src/source/page/compresspage.cpp:80`, `src/source/page/uncompresspage.cpp:120-121`, `src/source/page/homepage.cpp:47`, `src/source/page/progresspage.cpp:227-229`, `src/source/page/successpage.cpp:86-87`, `src/source/page/failurepage.cpp:103-104`, `src/source/dialog/popupdialog.cpp:353-356`, `src/source/dialog/settingdialog.cpp:133-137`, `src/source/dialog/progressdialog.cpp:62`.
</issue_to_address>5d04020 to
434f5e9
Compare
1. Add setAccessibleName() to 31 interactive controls across 10 files. 2. Cover compression, extraction, progress, result and settings pages. 3. Name radio buttons, input fields, switches, combos and buttons. Log: Add accessible names for AT-SPI automation support Influence: 1. Launch the app and verify all interactive controls render and respond. 2. Run AT-SPI inspection and confirm 31 controls expose accessible names. 3. Verify compression and extraction flows remain unaffected. fix: 为交互控件补充 AT-SPI 无障碍名称 1. 为 10 个文件中的 31 个交互控件增加 setAccessibleName()。 2. 覆盖压缩、解压、进度、结果及设置等页面。 3. 包含单选框、输入框、开关、下拉框和按钮等控件。 Influence: 1. 启动应用,验证各交互控件显示与交互正常。 2. 使用 AT-SPI 检查工具确认 31 个控件均可获取无障碍名称。 3. 验证压缩、解压等既有流程不受影响。 Log: 补充 AT-SPI 自动化测试所需的控件无障碍名称 PMS: TASK-398535 multica: V-8391
deepin pr auto review🤖 AI 代码审查报告📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价: 语法正确,逻辑清晰 ✅ 通过 潜在问题: 建议: [] 2. 代码质量 ✅评价: 代码结构清晰,注释完整 ✅ 通过 潜在问题: 建议: [] 3. 代码性能 ✅评价: 性能良好,资源使用合理 ✅ 通过 潜在问题: 建议: [] 4. 代码安全 🔒评价: 存在0个安全漏洞 ✅ 通过
安全漏洞详情: 建议: [] 💡 改进建议代码示例本报告由 AI 代码审查工具自动生成 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dengzhongyuan365-dev, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/merge |
Summary
Add
setAccessibleName()to 31 interactive controls across 10 source files to improve AT-SPI accessibility coverage for the archive manager (归档管理器).Changes by file
compresssettingpage.cppcompresspage.cppuncompresspage.cpphomepage.cppprogresspage.cppsuccesspage.cppfailurepage.cpppopupdialog.cppsettingdialog.cppprogressdialog.cppBuild verification
cmake .. -DCMAKE_BUILD_TYPE=Debug✅make -j$(nproc) deepin-compressor✅ (100% built, no errors)Related issue
V-8391: AT-补充-归档管理器
Summary by Sourcery
Improve archive manager accessibility by identifying interactive controls for assistive technologies.
New Features:
Chores: